Ticket #35273: 35273.3.diff

src/wp-admin/includes/nav-menu.php

@@ -937 +937 @@
  *
  * @since 3.0.0
  *
- * @return string|WP_Error $output The menu formatted to edit or error object on failure.
+ * @return array Columns.
  */
 function wp_nav_menu_manage_columns() {
         return array(
-                '_title' => __('Show advanced menu properties'),
-                'cb' => '<input type="checkbox" />',
-                'title-attribute' => __('Title Attribute'),
-                'link-target' => __('Link Target'),
-                'css-classes' => __('CSS Classes'),
-                'xfn' => __('Link Relationship (XFN)'),
-                'description' => __('Description'),
+                '_title'      => __( 'Show advanced menu properties' ),
+                'cb'          => '<input type="checkbox" />',
+                'link-target' => __( 'Link Target' ),
+                'attr-title'  => __( 'Title Attribute' ),
+                'css-classes' => __( 'CSS Classes' ),
+                'xfn'         => __( 'Link Relationship (XFN)' ),
+                'description' => __( 'Description' ),
         );
 }
 

src/wp-admin/js/customize-nav-menus.js

@@ -218 +218 @@
                                         .prop( 'tabIndex', -1 )
                                         .removeClass( 'is-visible' );
                         }
-                        
+
                         this.searchTerm = event.target.value;
                         this.pages.search = 1;
                         this.doSearch( 1 );
@@ -614 +614 @@
                         });
                 },
 
-                saveManageColumnsState: function() {
-                        var hidden = this.hidden();
-                        $.post( wp.ajax.settings.url, {
-                                action: 'hidden-columns',
-                                hidden: hidden,
+                saveManageColumnsState: _.debounce( function() {
+                        var panel = this;
+                        if ( panel._updateHiddenColumnsRequest ) {
+                                panel._updateHiddenColumnsRequest.abort();
+                        }
+
+                        panel._updateHiddenColumnsRequest = wp.ajax.post( 'hidden-columns', {
+                                hidden: panel.hidden(),
                                 screenoptionnonce: $( '#screenoptionnonce' ).val(),
                                 page: 'nav-menus'
-                        });
-                },
+                        } );
+                        panel._updateHiddenColumnsRequest.always( function() {
+                                panel._updateHiddenColumnsRequest = null;
+                        } );
+                }, 2000 ),
 
                 checked: function( column ) {
                         this.container.addClass( 'field-' + column + '-active' );
@@ -633 +639 @@
                 },
 
                 hidden: function() {
-                        this.hidden = function() {
-                                return $( '.hide-column-tog' ).not( ':checked' ).map( function() {
-                                        var id = this.id;
-                                        return id.substring( id, id.length - 5 );
-                                }).get().join( ',' );
-                        };
+                        return $( '.hide-column-tog' ).not( ':checked' ).map( function() {
+                                var id = this.id;
+                                return id.substring( 0, id.length - 5 );
+                        }).get().join( ',' );
                 }
         } );
 

src/wp-includes/customize/class-wp-customize-nav-menus-panel.php

@@ -34 +34 @@
          * @access public
          */
         public function render_screen_options() {
-                // Essentially adds the screen options.
-                add_filter( 'manage_nav-menus_columns', array( $this, 'wp_nav_menu_manage_columns' ) );
+                // Adds the screen options.
+                require_once ABSPATH . 'wp-admin/includes/nav-menu.php';
+                add_filter( 'manage_nav-menus_columns', 'wp_nav_menu_manage_columns' );
 
                 // Display screen options.
                 $screen = WP_Screen::get( 'nav-menus.php' );
@@ -48 +49 @@
          * Link title attribute added as it's a relatively advanced concept for new users.
          *
          * @since 4.3.0
-         * @access public
-         *
-         * @return array The advanced menu properties.
+         * @deprecated 4.5.0 Deprecated in favor of wp_nav_menu_manage_columns().
          */
         public function wp_nav_menu_manage_columns() {
-                return array(
-                        '_title'      => __( 'Show advanced menu properties' ),
-                        'cb'          => '<input type="checkbox" />',
-                        'link-target' => __( 'Link Target' ),
-                        'attr-title'  => __( 'Title Attribute' ),
-                        'css-classes' => __( 'CSS Classes' ),
-                        'xfn'         => __( 'Link Relationship (XFN)' ),
-                        'description' => __( 'Description' ),
-                );
+                _deprecated_function( __METHOD__, '4.5.0', 'wp_nav_menu_manage_columns' );
+                require_once ABSPATH . 'wp-admin/includes/nav-menu.php';
+                return wp_nav_menu_manage_columns();
         }
 
         /**