Ticket #36083: 36083.2.diff

src/wp-admin/includes/update-core.php

@@ -598 +598 @@
 'wp-admin/css/colors.min.css',
 'wp-admin/css/colors-rtl.css',
 'wp-admin/css/colors-rtl.min.css',
-'wp-admin/css/media-rtl.min.css',
-'wp-admin/css/media.min.css',
-'wp-admin/css/farbtastic-rtl.min.css',
+// Following files added back in 4.5 see #36083
+// 'wp-admin/css/media-rtl.min.css',
+// 'wp-admin/css/media.min.css',
+// 'wp-admin/css/farbtastic-rtl.min.css',
 'wp-admin/images/lock-2x.png',
 'wp-admin/images/lock.png',
 'wp-admin/js/theme-preview.js',

new file tests/phpunit/tests/admin/includesUpdateCore.php

@@ +1 @@
+<?php
+
+/**
+ * @group admin
+ * @group upgrade
+ */
+class Tests_Admin_IncludesUpdateCore extends WP_UnitTestCase {
+        public function data_old_files() {
+                global $_old_files;
+
+                require_once( ABSPATH . 'wp-admin/includes/update-core.php' );
+
+                foreach ( $_old_files as &$file ) {
+                        $file = array( $file );
+                }
+
+                return $_old_files;
+        }
+
+        /**
+         * Ensure no project files are inside `$_old_files`.
+         *
+         * @ticket 36083
+         *
+         * @dataProvider data_old_files
+         *
+         * @param string $file File name.
+         */
+        public function test_new_files_are_not_in_old_files_array( $file ) {
+                $this->assertFalse( file_exists( ABSPATH . $file ) );
+                $this->assertFalse( file_exists( ABSPATH . str_replace( '.min.', '.', $file ) ) );
+                $this->assertFalse( file_exists( ABSPATH . str_replace( '-rtl.min.', '.', $file ) ) );
+        }
+}