Ticket #36696: 36696.patch

src/wp-includes/class-wp-meta-query.php

@@ -594 +594 @@
                                 $meta_value = trim( $meta_value );
                         }
 
+                        if ( 'SIGNED' === $meta_type ) {
+                                $cast_string = '%d';
+                        } elseif ( 'UNSIGNED' === $meta_type ) {
+                                $cast_string = '%u';
+                        } else {
+                                $cast_string = '%s';
+                        }
+
                         switch ( $meta_compare ) {
                                 case 'IN' :
                                 case 'NOT IN' :
-                                        $meta_compare_string = '(' . substr( str_repeat( ',%s', count( $meta_value ) ), 1 ) . ')';
+                                        $meta_compare_string = '(' . substr( str_repeat( ',' . $cast_string, count( $meta_value ) ), 1 ) . ')';
                                         $where = $wpdb->prepare( $meta_compare_string, $meta_value );
                                         break;
 
@@ -604 +612 @@
                                 case 'BETWEEN' :
                                 case 'NOT BETWEEN' :
                                         $meta_value = array_slice( $meta_value, 0, 2 );
-                                        $where = $wpdb->prepare( '%s AND %s', $meta_value );
+                                        $where = $wpdb->prepare( $cast_string . ' AND ' . $cast_string, $meta_value );
                                         break;
 
                                 case 'LIKE' :
                                 case 'NOT LIKE' :
                                         $meta_value = '%' . $wpdb->esc_like( $meta_value ) . '%';
-                                        $where = $wpdb->prepare( '%s', $meta_value );
+                                        $where = $wpdb->prepare( '%s', $meta_value ); // Ignore $cast_string.
                                         break;
 
                                 // EXISTS with a value is interpreted as '='.
                                 case 'EXISTS' :
                                         $meta_compare = '=';
-                                        $where = $wpdb->prepare( '%s', $meta_value );
+                                        $where = $wpdb->prepare( $cast_string, $meta_value );
                                         break;
 
                                 // 'value' is ignored for NOT EXISTS.
@@ -625 +633 @@
                                         break;
 
                                 default :
-                                        $where = $wpdb->prepare( '%s', $meta_value );
+                                        $where = $wpdb->prepare( $cast_string, $meta_value );
                                         break;
 
                         }
 
-                        if ( $where ) {
+                        if ( '' !== $where ) {
                                 $sql_chunks['where'][] = "CAST($alias.meta_value AS {$meta_type}) {$meta_compare} {$where}";
                         }
                 }