Ticket #36696: 36696_tests.patch

tests/phpunit/tests/meta/query.php

@@ -884 +884 @@
 
                 $this->assertTrue( $q->has_or_relation() );
         }
+
+        /**
+         * @group 36696
+         */
+        function test_cast_both_sides() {
+                global $wpdb;
+
+                $query = new WP_Meta_Query( array(
+                        array(
+                                'key'       => 'number_string',
+                                'value'     => '1000000',
+                                'compare'   => '<=',
+                                'type'      => 'NUMERIC',
+                        ),
+                ) );
+
+                $sql = $query->get_sql( 'post', $wpdb->posts, 'ID', $this );
+                $this->assertNotContains( "CAST({$wpdb->postmeta}.meta_value AS SIGNED) <= '1000000'", $sql['where'] );
+                $this->assertContains( "CAST({$wpdb->postmeta}.meta_value AS SIGNED) <= 1000000", $sql['where'] );
+        }
 }

tests/phpunit/tests/query/metaQuery.php

@@ -1694 +1694 @@
 
                 $this->assertEqualSets( array( 'foo_key', 'foo_key-1', 'foo_key-2' ), array_keys( $q->meta_query->get_clauses() ) );
         }
+
+        /**
+         * @ticket 36696
+         */
+        public function test_cast_value_numeric_big() {
+                $posts = $this->factory->post->create_many( 1 );
+
+                // Will trigger (depending on system) MySQL string to float type conversion on quoted numbers.
+                $big_int = 0x20000000000001; // 0x20 0000 0000 0001 (54 bit integer + 1, 9007199254740993).
+                update_post_meta( $posts[0], 'foo', $big_int - 1 );
+
+                $q = new WP_Query( array(
+                        'update_post_meta_cache' => false,
+                        'update_term_meta_cache' => false,
+                        'fields' => 'ids',
+                        'meta_query' => array(
+                                array(
+                                        'key' => 'foo',
+                                        'value' => $big_int,
+                                        'compare' => '<',
+                                        'type' => 'NUMERIC',
+                                ),
+                        ),
+                ) );
+                
+                $this->assertEquals( array( $posts[0] ), $q->posts );
+        }
+
+        /**
+         * @ticket 36696
+         */
+        public function test_cast_value_numeric_max() {
+                $posts = $this->factory->post->create_many( 1 );
+
+                $max_int = PHP_INT_MAX;
+                update_post_meta( $posts[0], 'foo', $max_int - 1 );
+
+                $q = new WP_Query( array(
+                        'update_post_meta_cache' => false,
+                        'update_term_meta_cache' => false,
+                        'fields' => 'ids',
+                        'meta_query' => array(
+                                array(
+                                        'key' => 'foo',
+                                        'value' => $max_int,
+                                        'compare' => '<',
+                                        'type' => 'NUMERIC',
+                                ),
+                        ),
+                ) );
+                
+                $this->assertEquals( array( $posts[0] ), $q->posts );
+        }
+
+        /**
+         * @ticket 36696
+         */
+        public function test_cast_value_numeric_ignore_if_like() {
+                $posts = $this->factory->post->create_many( 1 );
+
+                update_post_meta( $posts[0], 'foo', 10101 );
+
+                $q = new WP_Query( array(
+                        'update_post_meta_cache' => false,
+                        'update_term_meta_cache' => false,
+                        'fields' => 'ids',
+                        'meta_query' => array(
+                                array(
+                                        'key' => 'foo',
+                                        'value' => 101,
+                                        'compare' => 'LIKE',
+                                        'type' => 'NUMERIC',
+                                ),
+                        ),
+                ) );
+                
+                $this->assertEquals( array( $posts[0] ), $q->posts );
+        }
 }