Ticket #36717: 36717.6.diff

src/wp-includes/ms-deprecated.php

@@ -506 +506 @@
         $results = array();
 
         foreach ( $_sites as $_site ) {
-                $results[] = (array) get_site( $_site );
+                $_site = get_site( $_site );
+                $results[] = $_site->to_array();
         }
 
         return $results;

tests/phpunit/tests/multisite/wpGetSites.php

@@ -3 +3 @@
 if ( is_multisite() ) :
 
 /**
+ * @group wp-get-site
  * @group ms-site
  * @group multisite
  */
@@ -33 +34 @@
 
         /**
          * @expectedDeprecated wp_get_sites
+         */
+        public function test_wp_get_sites_site_is_expected_array() {
+
+                $keys = array(
+                        'blog_id',
+                        'site_id',
+                        'domain',
+                        'path',
+                        'registered',
+                        'last_updated',
+                        'public',
+                        'archived',
+                        'mature',
+                        'spam',
+                        'deleted',
+                        'lang_id'
+                );
+                $sites = wp_get_sites();
+
+                $missing_keys = array_diff_key( array_flip( $keys ), $sites[0] );
+
+                $this->assertEquals( array(), $missing_keys, 'Keys are missing from site arrays.' );
+        }
+
+        /**
+         * @expectedDeprecated wp_get_sites
          * @dataProvider data_wp_get_sites
          *
          * @param $expected