Ticket #36905: 36905.3.patch

src/wp-includes/post.php

@@ -4326 +4326 @@
  * @return WP_Post|array|void WP_Post on success or null on failure
  */
 function get_page_by_title( $page_title, $output = OBJECT, $post_type = 'page' ) {
-        global $wpdb;
 
-        if ( is_array( $post_type ) ) {
-                $post_type = esc_sql( $post_type );
-                $post_type_in_string = "'" . implode( "','", $post_type ) . "'";
-                $sql = $wpdb->prepare( "
-                        SELECT ID
-                        FROM $wpdb->posts
-                        WHERE post_title = %s
-                        AND post_type IN ($post_type_in_string)
-                ", $page_title );
-        } else {
-                $sql = $wpdb->prepare( "
-                        SELECT ID
-                        FROM $wpdb->posts
-                        WHERE post_title = %s
-                        AND post_type = %s
-                ", $page_title, $post_type );
-        }
+        // Make sure that we actually get all the post statuses
+        $post_status = get_post_stati();
 
-        $page = $wpdb->get_var( $sql );
+        $query = new WP_Query(
+                array(
+                        'title'          => $page_title,
+                        'post_type'      => $post_type,
+                        'posts_per_page' => 1,
+                        'post_status'    => $post_status,
+                        'orderby'        => 'ID',
+                        'order'          => 'ASC',
+                        'fields'         => 'ids'
+                )
+        );
+        $posts = $query->get_posts();
 
-        if ( $page ) {
-                return get_post( $page, $output );
+        if ( $posts ) {
+                return get_post( $posts[0], $output );
         }
 }
 

tests/phpunit/tests/post/getPageByTitle.php

@@ +1 @@
+<?php
+
+/**
+ * @group post
+ */
+class Tests_Post_GetPageByTitle extends WP_UnitTestCase {
+
+        /**
+         * @ticket 36905
+         */
+        public function test_get_page_by_title() {
+                $page_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+                $page = get_page_by_title( 'some Page' );
+                $this->assertEquals( $page_id, $page->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_not_care_about_cases() {
+                $page_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+                $page = get_page_by_title( 'soMe paGE' );
+                $this->assertEquals( $page_id, $page->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_match_exact_title() {
+                $page_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+
+                $page = get_page_by_title( 'Some Page Yeah' );
+                $this->assertNull( $page );
+
+                $page = get_page_by_title( 'Yeah Some Page' );
+                $this->assertNull( $page );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_return_one_result_if_some_posts_has_the_same_title() {
+                $post_id_1       = self::factory()->post->create_object( array( 'post_title' => 'Some Title', 'post_type' => 'page' ) );
+                $post_id_2       = self::factory()->post->create_object( array( 'post_title' => 'Some Title', 'post_type' => 'page' ) );
+                $post = get_page_by_title( 'Some Title' );
+                $this->assertEquals( $post_id_1, $post->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_obey_post_type() {
+                register_post_type( 'my-cpt' );
+                $post_id       = self::factory()->post->create_object( array( 'post_title' => 'Some CPT', 'post_type' => 'my-cpt' ) );
+
+                $post = get_page_by_title( 'Some CPT', OBJECT, 'my-cpt' );
+                $this->assertEquals( $post_id, $post->ID );
+
+                $post = get_page_by_title( 'Some CPT', OBJECT, 'page' );
+                $this->assertNull( $post );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_get_different_post_types() {
+                register_post_type( 'my-cpt' );
+                $post_id_1       = self::factory()->post->create_object( array( 'post_title' => 'Some CPT', 'post_type' => 'my-cpt' ) );
+                $post_id_2       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+                $post = get_page_by_title( 'Some Page', OBJECT, array( 'my-cpt', 'page' ) );
+                $this->assertEquals( $post_id_2, $post->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_get_different_post_statuses() {
+                register_post_type( 'my-cpt' );
+                $post_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Trashed post', 'post_type' => 'page', 'post_status' => 'trash' ) );
+                $found = get_page_by_title( 'Some Trashed post' );
+                $this->assertEquals( $post_id, $found->ID );
+
+                $post_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Auto Draft post', 'post_type' => 'page', 'post_status' => 'auto-draft' ) );
+                $found = get_page_by_title( 'Some Auto Draft post' );
+                $this->assertEquals( $post_id, $found->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_output_param_should_be_obeyed() {
+                $post_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+
+                $found = get_page_by_title( 'Some Page' );
+                $this->assertInternalType( 'object', $found );
+                $this->assertSame( $post_id, $found->ID );
+
+                $found = get_page_by_title( 'Some Page', OBJECT );
+                $this->assertInternalType( 'object', $found );
+                $this->assertSame( $post_id, $found->ID );
+
+                $found = get_page_by_title( 'Some Page', ARRAY_N );
+                $this->assertInternalType( 'array', $found );
+                $this->assertSame( $post_id, $found[0] );
+
+                $found = get_page_by_title( 'Some Page', ARRAY_A );
+                $this->assertInternalType( 'array', $found );
+                $this->assertSame( $post_id, $found['ID'] );
+        }
+
+
+
+}