Ticket #36905: 36905.7.patch

src/wp-includes/post.php

@@ -4771 +4771 @@
  * @return WP_Post|array|null WP_Post (or array) on success, or null on failure.
  */
 function get_page_by_title( $page_title, $output = OBJECT, $post_type = 'page' ) {
-        global $wpdb;
 
-        if ( is_array( $post_type ) ) {
-                $post_type           = esc_sql( $post_type );
-                $post_type_in_string = "'" . implode( "','", $post_type ) . "'";
-                $sql                 = $wpdb->prepare(
-                        "
-                        SELECT ID
-                        FROM $wpdb->posts
-                        WHERE post_title = %s
-                        AND post_type IN ($post_type_in_string)
-                ",
-                        $page_title
-                );
-        } else {
-                $sql = $wpdb->prepare(
-                        "
-                        SELECT ID
-                        FROM $wpdb->posts
-                        WHERE post_title = %s
-                        AND post_type = %s
-                ",
-                        $page_title,
-                        $post_type
-                );
+        $last_changed = wp_cache_get_last_changed( 'posts' );
+
+        $hash      = md5( $page_title . serialize( $post_type ) );
+        $cache_key = "get_page_by_title:$hash:$last_changed";
+        $cached    = wp_cache_get( $cache_key, 'posts' );
+        if ( false !== $cached ) {
+                // Special case: '0' is a bad `$page_path`.
+                if ( '0' === $cached || 0 === $cached ) {
+                        return null;
+                } else {
+                        return get_post( $cached, $output );
+                }
         }
 
-        $page = $wpdb->get_var( $sql );
+        // Make sure that we even query post statuses that are excluded from search
+        $post_status = array_values( get_post_stati( array( 'exclude_from_search' => true ) ) );
+        $posts       = get_posts(
+                array(
+                        'title'            => $page_title,
+                        'post_type'        => $post_type,
+                        'posts_per_page'   => 1,
+                        'post_status'      => array_merge( $post_status, array( 'any' ) ),
+                        'orderby'          => 'none',
+                        'suppress_filters' => false,
+                        'fields'           => 'ids',
+                )
+        );
 
-        if ( $page ) {
-                return get_post( $page, $output );
+
+        if ( $posts ) {
+                wp_cache_set( $cache_key, $posts[0], 'posts' );
+
+                return get_post( $posts[0], $output );
         }
+
+        // Cache a miss as well.
+        wp_cache_set( $cache_key, 0, 'posts' );
+
+        return null;
 }
 
 /**

tests/phpunit/tests/post/getPageByTitle.php

@@ +1 @@
+<?php
+
+/**
+ * @group post
+ */
+class Tests_Post_GetPageByTitle extends WP_UnitTestCase {
+
+        /**
+         * @ticket 36905
+         */
+        public function test_get_page_by_title() {
+                $page_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+                $page = get_page_by_title( 'some Page' );
+                $this->assertEquals( $page_id, $page->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_not_care_about_cases() {
+                $page_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+                $page = get_page_by_title( 'soMe paGE' );
+                $this->assertEquals( $page_id, $page->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_match_exact_title() {
+                $page_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+
+                $page = get_page_by_title( 'Some Page Yeah' );
+                $this->assertNull( $page );
+
+                $page = get_page_by_title( 'Yeah Some Page' );
+                $this->assertNull( $page );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_return_one_result_if_some_posts_has_the_same_title() {
+                $post_id_1       = self::factory()->post->create_object( array( 'post_title' => 'Some Title', 'post_type' => 'page' ) );
+                $post_id_2       = self::factory()->post->create_object( array( 'post_title' => 'Some Title', 'post_type' => 'page' ) );
+                $post = get_page_by_title( 'Some Title' );
+                $this->assertEquals( $post_id_1, $post->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_obey_post_type() {
+                register_post_type( 'my-cpt' );
+                $post_id       = self::factory()->post->create_object( array( 'post_title' => 'Some CPT', 'post_type' => 'my-cpt' ) );
+
+                $post = get_page_by_title( 'Some CPT', OBJECT, 'my-cpt' );
+                $this->assertEquals( $post_id, $post->ID );
+
+                $post = get_page_by_title( 'Some CPT', OBJECT, 'page' );
+                $this->assertNull( $post );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_get_different_post_types() {
+                register_post_type( 'my-cpt' );
+                $post_id_1       = self::factory()->post->create_object( array( 'post_title' => 'Some CPT', 'post_type' => 'my-cpt' ) );
+                $post_id_2       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+                $post = get_page_by_title( 'Some Page', OBJECT, array( 'my-cpt', 'page' ) );
+                $this->assertEquals( $post_id_2, $post->ID );
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_should_get_different_post_statuses() {
+                register_post_type( 'my-cpt' );
+
+                $post_statuses = get_post_stati();
+                foreach ( $post_statuses as $post_status ) {
+                        $title = sprintf( 'Some %s post', $post_status );
+                        $post_id       = self::factory()->post->create_object( array( 'post_title' => $title, 'post_type' => 'page', 'post_status' => $post_status ) );
+                        $found = get_page_by_title( $title );
+                        $this->assertEquals( $post_id, $found->ID );
+                }
+        }
+
+        /**
+         * @ticket 36905
+         */
+        public function test_output_param_should_be_obeyed() {
+                $post_id       = self::factory()->post->create_object( array( 'post_title' => 'Some Page', 'post_type' => 'page' ) );
+
+                $found = get_page_by_title( 'Some Page' );
+                $this->assertInternalType( 'object', $found );
+                $this->assertSame( $post_id, $found->ID );
+
+                $found = get_page_by_title( 'Some Page', OBJECT );
+                $this->assertInternalType( 'object', $found );
+                $this->assertSame( $post_id, $found->ID );
+
+                $found = get_page_by_title( 'Some Page', ARRAY_N );
+                $this->assertInternalType( 'array', $found );
+                $this->assertSame( $post_id, $found[0] );
+
+                $found = get_page_by_title( 'Some Page', ARRAY_A );
+                $this->assertInternalType( 'array', $found );
+                $this->assertSame( $post_id, $found['ID'] );
+        }
+
+
+
+}