Ticket #36961: 36961.3.diff

src/wp-includes/class-wp-user.php

@@ -88 +88 @@
         public $allcaps = array();
 
         /**
+         * The site ID the roles of this user are initialized for.
+         *
+         * @since 4.8.0
+         * @access private
+         * @var int
+         */
+        private $blog_id = 0;
+
+        /**
          * The filter context applied to user data fields.
          *
          * @since 2.9.0
@@ -247 +256 @@
         }
 
         /**
-         * Makes private/protected methods readable for backward compatibility.
-         *
-         * @since 4.3.0
-         * @access public
-         *
-         * @param callable $name      Method to call.
-         * @param array    $arguments Arguments to pass when calling.
-         * @return mixed|false Return value of the callback, false otherwise.
-         */
-        public function __call( $name, $arguments ) {
-                if ( '_init_caps' === $name ) {
-                        return call_user_func_array( array( $this, $name ), $arguments );
-                }
-                return false;
-        }
-
-        /**
          * Magic method for checking the existence of a certain custom field.
          *
          * @since 3.3.0
@@ -446 +438 @@
          *
          * @access protected
          * @since 2.1.0
+         * @deprecated 4.8.0
          *
          * @global wpdb $wpdb WordPress database abstraction object.
          *
@@ -454 +447 @@
         protected function _init_caps( $cap_key = '' ) {
                 global $wpdb;
 
-                if ( empty($cap_key) )
-                        $this->cap_key = $wpdb->get_blog_prefix() . 'capabilities';
-                else
+                _deprecated_function( __METHOD__, '4.8.0' );
+
+                if ( empty($cap_key) ) {
+                        $this->cap_key = $wpdb->get_blog_prefix( $this->blog_id ) . 'capabilities';
+                } else {
                         $this->cap_key = $cap_key;
+                }
 
                 $this->caps = get_user_meta( $this->ID, $this->cap_key, true );
 
@@ -481 +477 @@
          * @return array List of all capabilities for the user.
          */
         public function get_role_caps() {
+                $switch_site = false;
+                if ( is_multisite() && $this->blog_id !== get_current_blog_id() ) {
+                        $switch_site = $this->blog_id;
+
+                        switch_to_blog( $switch_site );
+                }
+
                 $wp_roles = wp_roles();
 
                 //Filter out caps that are not role names and assign to $this->roles
@@ -495 +498 @@
                 }
                 $this->allcaps = array_merge( (array) $this->allcaps, (array) $this->caps );
 
+                if ( $switch_site ) {
+                        restore_current_blog();
+                }
+
                 return $this->allcaps;
         }
 
@@ -783 +790 @@
          */
         public function for_blog( $blog_id = '' ) {
                 global $wpdb;
-                if ( ! empty( $blog_id ) )
-                        $cap_key = $wpdb->get_blog_prefix( $blog_id ) . 'capabilities';
-                else
-                        $cap_key = '';
-                $this->_init_caps( $cap_key );
+
+                if ( ! empty( $blog_id ) ) {
+                        $this->blog_id = absint( $blog_id );
+                } else {
+                        $this->blog_id = get_current_blog_id();
+                }
+
+                $this->cap_key = $wpdb->get_blog_prefix( $this->blog_id ) . 'capabilities';
+
+                $this->caps = get_user_meta( $this->ID, $this->cap_key, true );
+
+                if ( ! is_array( $this->caps ) ) {
+                        $this->caps = array();
+                }
+
+                $this->get_role_caps();
         }
 }

tests/phpunit/tests/user/capabilities.php

@@ -1774 +1774 @@
                 $this->assertFalse( user_can( self::$users['contributor']->ID,   'remove_user', self::$users['contributor']->ID ) );
                 $this->assertFalse( user_can( self::$users['subscriber']->ID,    'remove_user', self::$users['subscriber']->ID ) );
         }
+
+        /**
+         * @ticket 36961
+         */
+        function test_init_user_caps_for_different_site() {
+                global $wpdb;
+
+                if ( ! is_multisite() ) {
+                        $this->markTestSkipped( 'Test only runs in multisite' );
+                }
+
+                $site_id = self::factory()->blog->create( array( 'user_id' => self::$users['administrator']->ID ) );
+
+                switch_to_blog( $site_id );
+
+                $role_name = 'uploader';
+                add_role( $role_name, 'Uploader', array(
+                        'read'         => true,
+                        'upload_files' => true,
+                ) );
+                add_user_to_blog( $site_id, self::$users['subscriber']->ID, $role_name );
+
+                restore_current_blog();
+
+                $user = new WP_User( self::$users['subscriber']->ID, '', $site_id );
+                $this->assertTrue( $user->has_cap( 'upload_files' ) );
+        }
 }

tests/phpunit/tests/user.php

@@ -180 +180 @@
                 $this->assertEquals( 'foo', $user->$key );
                 $this->assertEquals( 'foo', $user->data->$key );  // This will fail with WP < 3.3
 
-                foreach ( (array) $user as $key => $value ) {
+                foreach ( get_object_vars( $user ) as $key => $value ) {
                         $this->assertEquals( $value, $user->$key );
                 }
         }