Ticket #37082: 0003-Remove-unnecessary-use-of-create_function-in-PO-prep.patch

wp-includes/pomo/po.php

@@ -167 +167 @@
          * @param string $with prepend lines with this string
          */
         public static function prepend_each_line($string, $with) {
-                $php_with = var_export($with, true);
                 $lines = explode("\n", $string);
-                // do not prepend the string on the last empty line, artefact by explode
-                if ("\n" == substr($string, -1)) unset($lines[count($lines) - 1]);
-                $res = implode("\n", array_map(create_function('$x', "return $php_with.\$x;"), $lines));
-                // give back the empty line, we ignored above
-                if ("\n" == substr($string, -1)) $res .= "\n";
-                return $res;
+                $append = '';
+                if ( '' === end($lines) ) {
+                        // Last line might be empty because $string was terminated
+                        // with a newline, remove it from the $lines array,
+                        // we'll restore state by re-terminating the string at the end
+                        array_pop($lines);
+                        $append = "\n";
+                }
+                foreach ( $lines as &$line ) {
+                        $line = $with . $line;
+                }
+                unset($line);
+                return implode("\n", $lines) . $append;
         }
 
         /**