Ticket #37082: 37082.2.diff

tests/phpunit/tests/customize/setting.php

@@ -48 +48 @@
                 $this->assertEquals( false, $setting->dirty );
         }
 
+    /**
+     * A test validate callback function.
+     */
+    function validate_callback_for_tests( $value ) {
+        return $value . ':validate_callback';
+    }
+
+        /**
+        * A test sanitize callback function.
+        */
+        function sanitize_callback_for_tests( $value ) {
+                return $value . ':sanitize_callback';
+        }
+
+        /**
+         * A test sanitize JS callback function.
+         */
+        function sanitize_js_callback_for_tests( $value ) {
+                return $value . ':sanitize_js_callback';
+        }
+
         function test_constructor_with_args() {
                 $args = array(
                         'type' => 'option',
@@ -55 +76 @@
                         'theme_supports' => 'widgets',
                         'default' => 'barbar',
                         'transport' => 'postMessage',
-                        'validate_callback' => create_function( '$value', 'return $value . ":validate_callback";' ),
-                        'sanitize_callback' => create_function( '$value', 'return $value . ":sanitize_callback";' ),
-                        'sanitize_js_callback' => create_function( '$value', 'return $value . ":sanitize_js_callback";' ),
+                        'validate_callback' => array( $this, 'validate_callback_for_tests' ),
+                        'sanitize_callback' => array( $this, 'sanitize_callback_for_tests' ),
+                        'sanitize_js_callback' => array( $this, 'sanitize_js_callback_for_tests' ),
                 );
                 $setting = new WP_Customize_Setting( $this->manager, 'bar', $args );
                 $this->assertEquals( 'bar', $setting->id );
@@ -603 +624 @@
         }
 
         /**
+         * Sanitize JS callback for base64 encoding.
+         */
+        function sanitize_js_callback_base64_for_testing( $value ) {
+                return base64_encode( $value );
+        }
+
+        /**
          * Test js_value and json methods.
          *
          * @see WP_Customize_Setting::js_value()
@@ -615 +643 @@
                         'default' => $default,
                         'transport' => 'postMessage',
                         'dirty' => true,
-                        'sanitize_js_callback' => create_function( '$value', 'return base64_encode( $value );' ),
+                        'sanitize_js_callback' => array( $this, 'sanitize_js_callback_base64_for_testing' ),
                 );
                 $setting = new WP_Customize_Setting( $this->manager, 'name', $args );
 

tests/phpunit/tests/image/editor.php

@@ -46 +46 @@
         }
 
         /**
+         * Return integer of 95 for testing.
+         */
+        function return_integer_95() {
+                return 95;
+        }
+
+        /**
+         * Return integer of 100 for testing.
+         */
+        function return_integer_100() {
+                return 100;
+        }
+
+        /**
          * Test test_quality
          * @ticket 6821
          */
@@ -59 +73 @@
                 $this->assertEquals( 82, $editor->get_quality() );
 
                 // Ensure the quality filters do not have precedence if created after editor instantiation.
-                $func_100_percent = create_function( '', "return 100;" );
+                $func_100_percent = array( $this, 'return_integer_100' );
                 add_filter( 'wp_editor_set_quality', $func_100_percent );
                 $this->assertEquals( 82, $editor->get_quality() );
 
-                $func_95_percent = create_function( '', "return 95;" );
+                $func_95_percent = array( $this, 'return_integer_95' );
                 add_filter( 'jpeg_quality', $func_95_percent );
                 $this->assertEquals( 82, $editor->get_quality() );