Ticket #37151: 37151.diff

src/wp-includes/class-wp-meta-query.php

@@ -327 +327 @@
                         return false;
                 }
 
+                $this->table_aliases = array();
+
                 $this->meta_table     = $meta_table;
                 $this->meta_id_column = sanitize_key( $type . '_id' );
 

src/wp-includes/class-wp-term-query.php

@@ -814 +814 @@
         protected function parse_orderby_meta( $orderby_raw ) {
                 $orderby = '';
 
+                // Tell the meta query to generate its SQL, so we have access to table aliases.
+                $this->meta_query->get_sql( 'term', 't', 'term_id' );
                 $meta_clauses = $this->meta_query->get_clauses();
                 if ( ! $meta_clauses || ! $orderby_raw ) {
                         return $orderby;

tests/phpunit/tests/term/query.php

@@ -61 +61 @@
 
                 $this->assertEqualSets( array( $terms[0], $terms[2] ), $q->terms );
         }
+
+        /**
+         * @ticket 37151
+         */
+        public function test_order_by_meta_value_num() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
+
+                add_term_meta( $terms[0], 'foo', 10 );
+                add_term_meta( $terms[1], 'foo', 1 );
+                add_term_meta( $terms[2], 'foo', 100 );
+
+                $q = new WP_Term_Query( array(
+                        'taxonomy' => array( 'wptests_tax' ),
+                        'fields' => 'ids',
+                        'hide_empty' => false,
+                        'meta_key' => 'foo',
+                        'orderby' => 'meta_value_num',
+                ) );
+
+                $found = array_map( 'intval', $q->terms );
+                $this->assertSame( array( $terms[1], $terms[0], $terms[2] ), $found );
+        }
 }