Ticket #37186: 37186.diff

src/wp-admin/includes/class-wp-media-list-table.php

@@ -474 +474 @@
                 }
 
                 if ( $parent ) {
-                        $title = _draft_or_post_title( $post->post_parent );
                         $parent_type = get_post_type_object( $parent->post_type );
+                        
+                        if ( $parent_type && $parent_type->show_ui && current_user_can( 'edit_post', $post->post_parent ) ) {
+                                $title = _draft_or_post_title( $post->post_parent );
 ?>
-                        <strong>
-                        <?php if ( $parent_type && $parent_type->show_ui && current_user_can( 'edit_post', $post->post_parent ) ) { ?>
-                                <a href="<?php echo get_edit_post_link( $post->post_parent ); ?>">
-                                        <?php echo $title ?></a><?php
+                                <strong><a href="<?php echo get_edit_post_link( $post->post_parent ); ?>">
+                                        <?php echo $title ?></a></strong><?php
                         } else {
-                                echo $title;
-                        } ?></strong>
-                        <br />
-                        <?php
+                                _e( '(Private post)' );
+                        }
+
                         if ( $user_can_edit ):
                                 $detach_url = add_query_arg( array(
                                         'parent_post_id' => $post->post_parent,
@@ -493 +492 @@
                                         '_wpnonce' => wp_create_nonce( 'bulk-' . $this->_args['plural'] )
                                 ), 'upload.php' );
                                 printf(
-                                        '<a href="%s" class="hide-if-no-js detach-from-parent" aria-label="%s">%s</a>',
+                                        '<br /><a href="%s" class="hide-if-no-js detach-from-parent" aria-label="%s">%s</a>',
                                         $detach_url,
                                         /* translators: %s: title of the post the attachment is attached to */
                                         esc_attr( sprintf( __( 'Detach from &#8220;%s&#8221;' ), $title ) ),
@@ -501 +500 @@
                                 );
                         endif;
                 } else {
-                        _e( '(Unattached)' ); ?><br />
+                        _e( '(Unattached)' ); ?>
                         <?php if ( $user_can_edit ) {
                                 $title = _draft_or_post_title( $post->post_parent );
                                 printf(
-                                        '<a href="#the-list" onclick="findPosts.open( \'media[]\', \'%s\' ); return false;" class="hide-if-no-js" aria-label="%s">%s</a>',
+                                        '<br /><a href="#the-list" onclick="findPosts.open( \'media[]\', \'%s\' ); return false;" class="hide-if-no-js" aria-label="%s">%s</a>',
                                         $post->ID,
                                         /* translators: %s: attachment title */
                                         esc_attr( sprintf( __( 'Attach &#8220;%s&#8221; to existing content' ), $title ) ),

src/wp-includes/media.php

@@ -3064 +3064 @@
                 $parent_type = get_post_type_object( $post_parent->post_type );
                 if ( $parent_type && $parent_type->show_ui && current_user_can( 'edit_post', $attachment->post_parent ) ) {
                         $response['uploadedToLink'] = get_edit_post_link( $attachment->post_parent, 'raw' );
+                        $response['uploadedToTitle'] = $post_parent->post_title ? $post_parent->post_title : __( '(no title)' );
                 }
-                $response['uploadedToTitle'] = $post_parent->post_title ? $post_parent->post_title : __( '(no title)' );
         }
 
         $attached_file = get_attached_file( $attachment->ID );