Ticket #37407: 37407.2.diff

src/wp-admin/includes/class-wp-list-table.php

@@ -1175 +1175 @@
                 if ( 'top' === $which ) {
                         wp_nonce_field( 'bulk-' . $this->_args['plural'] );
                 }
-                ?>
-        <div class="tablenav <?php echo esc_attr( $which ); ?>">
 
-                <?php if ( $this->has_items() ): ?>
-                <div class="alignleft actions bulkactions">
-                        <?php $this->bulk_actions( $which ); ?>
-                </div>
-                <?php endif;
-                $this->extra_tablenav( $which );
-                $this->pagination( $which );
-?>
-
-                <br class="clear" />
-        </div>
-<?php
+                if ( $this->has_items() ): ?>
+                        <div class="tablenav <?php echo esc_attr( $which ); ?>">
+                                <div class="alignleft actions bulkactions">
+                                        <?php $this->bulk_actions( $which ); ?>
+                                </div>
+                                <?php $this->extra_tablenav( $which );
+                                $this->pagination( $which ); ?>
+                                <br class="clear"/>
+                        </div>
+                        <?php
+                endif;
         }
 
         /**

tests/phpunit/tests/admin/includesListTable.php

@@ -9 +9 @@
         protected static $grandchildren = array();
         protected static $post_ids = array();
 
+        /**
+         * @var WP_Posts_List_Table
+         */
+        protected $table;
+
         function setUp() {
                 parent::setUp();
                 set_current_screen( 'edit-page' );
@@ -191 +196 @@
                 }
         }
 
+        /**
+         * @ticket 37407
+         */
+        public function test_tablenav_is_not_shown_when_there_are_no_items() {
+                ob_start();
+                $this->table->display();
+                $output = ob_get_clean();
+
+                $this->assertNotContains( '<div class="tablenav', $output );
+        }
 }