Ticket #37407: 37407.5.diff

src/wp-admin/includes/class-wp-posts-list-table.php

@@ -459 +459 @@
                 <div class="alignleft actions">
 <?php
                 if ( 'top' === $which && !is_singular() ) {
+                        ob_start();
 
                         $this->months_dropdown( $this->screen->post_type );
                         $this->categories_dropdown( $this->screen->post_type );
@@ -479 +480 @@
                          */
                         do_action( 'restrict_manage_posts', $this->screen->post_type, $which );
 
-                        submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+                        $output = ob_get_clean();
+
+                        if ( ! empty( $output ) ) {
+                                echo $output;
+                                submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+                        }
                 }
 
                 if ( $this->is_trash && current_user_can( get_post_type_object( $this->screen->post_type )->cap->edit_others_posts ) ) {
@@ -1552 +1558 @@
         <?php foreach ( $flat_taxonomies as $taxonomy ) : ?>
                 <?php if ( current_user_can( $taxonomy->cap->assign_terms ) ) :
                         $taxonomy_name = esc_attr( $taxonomy->name );
-        
+
                         ?>
                         <label class="inline-edit-tags">
                                 <span class="title"><?php echo esc_html( $taxonomy->labels->name ) ?></span>

tests/phpunit/tests/admin/includesListTable.php

@@ -191 +191 @@
                 }
         }
 
+        function test_list_filter_button( ) {
+                global $wp_query;
+
+                $cpt_table = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => 'page' ) );
+                $args = array(
+                        'post_type' => 'page',
+                        'orderby' => 'title',
+                        'order' => 'asc',
+                        'posts_per_page' => '-1',
+                );
+                $wp_query = new WP_Query( $args );
+                
+                ob_start();
+                $cpt_table->prepare_items();
+                $cpt_table->extra_tablenav('top');
+                $output = ob_get_clean();
+
+                $this->assertNotContains( '<div class="tablenav', $output );
+
+        }
+
 }