Ticket #37407: 37407.7.diff

src/wp-admin/includes/class-wp-posts-list-table.php

@@ -459 +459 @@
                 <div class="alignleft actions">
 <?php
                 if ( 'top' === $which && !is_singular() ) {
+                        ob_start();
 
                         $this->months_dropdown( $this->screen->post_type );
                         $this->categories_dropdown( $this->screen->post_type );
@@ -479 +480 @@
                          */
                         do_action( 'restrict_manage_posts', $this->screen->post_type, $which );
 
-                        submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+                        $output = ob_get_clean();
+
+                        if ( ! empty( $output ) ) {
+                                echo $output;
+                                submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+                        }
                 }
 
                 if ( $this->is_trash && current_user_can( get_post_type_object( $this->screen->post_type )->cap->edit_others_posts ) ) {
@@ -1552 +1558 @@
         <?php foreach ( $flat_taxonomies as $taxonomy ) : ?>
                 <?php if ( current_user_can( $taxonomy->cap->assign_terms ) ) :
                         $taxonomy_name = esc_attr( $taxonomy->name );
-        
+
                         ?>
                         <label class="inline-edit-tags">
                                 <span class="title"><?php echo esc_html( $taxonomy->labels->name ) ?></span>

tests/phpunit/tests/admin/includesListTable.php

@@ -9 +9 @@
         protected static $grandchildren = array();
         protected static $post_ids = array();
 
+        /**
+         * @var WP_Posts_List_Table
+         */
+        protected $table;
+
         function setUp() {
                 parent::setUp();
                 set_current_screen( 'edit-page' );
@@ -191 +196 @@
                 }
         }
 
+        /**
+         * @ticket 37407
+         */
+        function test_filter_button_should_not_be_shown_if_there_are_not_posts() {
+                // Set post type to a non-existent one.
+                $this->table->screen->post_type = 'foo';
+
+                ob_start();
+                $this->table->extra_tablenav( 'top' );
+                $output = ob_get_clean();
+
+                $this->assertNotContains( 'id="post-query-submit"', $output );
+        }
+
+        /**
+         * @ticket 37407
+         */
+        function test_months_dropdown_should_not_be_shown_if_there_are_not_posts() {
+                // Set post type to a non-existent one.
+                $this->table->screen->post_type = 'foo';
+
+                ob_start();
+                $this->table->extra_tablenav( 'top' );
+                $output = ob_get_clean();
+
+                $this->assertNotContains( 'id="filter-by-date"', $output );
+        }
+
+        /**
+         * @ticket 37407
+         */
+        function test_category_dropdown_should_not_be_shown_if_there_are_not_posts() {
+                // Set post type to a non-existent one.
+                $this->table->screen->post_type = 'foo';
+
+                ob_start();
+                $this->table->extra_tablenav( 'top' );
+                $output = ob_get_clean();
+
+                $this->assertNotContains( 'id="cat"', $output );
+        }
 }