Ticket #37563: 37563.2.diff

src/wp-admin/js/updates.js

@@ -1466 +1466 @@
                         return;
                 }
 
-                _.each( wp.updates.queue, function( job ) {
-                        $document.trigger( 'credential-modal-cancel', job );
-                } );
+                $document.trigger( 'credential-modal-cancel', wp.updates.queue.pop() );
 
                 // Remove the lock, and clear the queue.
                 wp.updates.ajaxLocked = false;
@@ -1982 +1980 @@
                                         return;
                         }
 
-                        wp.updates.maybeRequestFilesystemCredentials( event );
-
                         event.preventDefault();
 
                         // Un-check the bulk checkboxes.
@@ -1996 +1992 @@
                                 var $checkbox  = $( element ),
                                         $itemRow = $checkbox.parents( 'tr' );
 
-                                // Un-check the box.
-                                $checkbox.prop( 'checked', false );
-
                                 // Only add update-able items to the update queue.
                                 if ( 'update-selected' === bulkAction && ( ! $itemRow.hasClass( 'update' ) || $itemRow.find( 'notice-error' ).length ) ) {
+
+                                        // Un-check the box.
+                                        $checkbox.prop( 'checked', false );
                                         return;
                                 }
 
@@ -2016 +2012 @@
 
                         // Display bulk notification for updates of any kind.
                         $document.on( 'wp-plugin-update-success wp-plugin-update-error wp-theme-update-success wp-theme-update-error', function( event, response ) {
-                                var $bulkActionNotice, itemName;
+                                var $itemRow = $( '[data-plugin="' + response.plugin + '"]' ),
+                                        $bulkActionNotice, itemName;
 
                                 if ( 'wp-' + response.update + '-update-success' === event.type ) {
                                         success++;
                                 } else {
-                                        itemName = response.pluginName ? response.pluginName : $( '[data-slug="' + response.slug + '"]' ).find( '.theme-title strong' ).text();
+                                        itemName = response.pluginName ? response.pluginName : $itemRow.find( '.theme-title strong' ).text();
 
                                         error++;
                                         errorMessages.push( itemName + ': ' + response.errorMessage );
                                 }
 
+                                $itemRow.find( 'input[name="checked[]"]:checked' ).prop( 'checked', false );
+
                                 wp.updates.adminNotice = wp.template( 'wp-bulk-updates-admin-notice' );
 
                                 wp.updates.addAdminNotice( {