Ticket #37703: 37703.unifinished.patch

src/wp-includes/comment.php

@@ -1376 +1376 @@
  *
  * @param int|WP_Comment $comment_id   Comment ID or WP_Comment object.
  * @param bool           $force_delete Whether to bypass trash and force deletion. Default is false.
+ * @param bool           $bulk         Some behaviours are delegate to the bulk function wp_delete_comments. Default is false.
  * @return bool True on success, false on failure.
  */
-function wp_delete_comment( $comment_id, $force_delete = false ) {
+function wp_delete_comment( $comment_id, $force_delete = false, $bulk = false ) {
         global $wpdb;
         $comment = get_comment( $comment_id );
         if ( ! $comment ) {
@@ -1400 +1401 @@
          */
         do_action( 'delete_comment', $comment->comment_ID, $comment );
 
-        // Move children up a level.
-        $children = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_parent = %d", $comment->comment_ID ) );
-        if ( ! empty( $children ) ) {
-                $wpdb->update( $wpdb->comments, array( 'comment_parent' => $comment->comment_parent ), array( 'comment_parent' => $comment->comment_ID ) );
-                clean_comment_cache( $children );
+        if ( !$bulk ) {
+                // Move children up a level.
+                $children = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_parent = %d", $comment->comment_ID ) );
+                if ( ! empty( $children ) ) {
+                        $wpdb->update( $wpdb->comments, array( 'comment_parent' => $comment->comment_parent ), array( 'comment_parent' => $comment->comment_ID ) );
+                        clean_comment_cache( $children );
+                }
         }
 
         // Delete metadata
@@ -1442 +1445 @@
         return true;
 }
 
+/**
+ * Trashes or deletes comments.
+ *
+ * The comments are moved to trash instead of permanently deleted unless trash is
+ * disabled, item is already in the trash, or $force_delete is true.
+ *
+ * The post comment count will be updated if the comments were approved and have a
+ * post ID available.
+ *
+ * @since x.x.x
+ *
+ * @global wpdb $wpdb WordPress database abstraction object.
+ *
+ * @param array $comments_id   Comment ID or WP_Comment object.
+ * @param bool  $force_delete Whether to bypass trash and force deletion. Default is false.
+ * @return bool True on success, false on failure.
+ */
+function wp_delete_comments( $comments_id, $force_delete = false ) {
+        global $wpdb;
+        $grandparents = array();
+        $ancestors = array();
+        if ( empty( $comments_id ) ) {
+                return true;
+        }
+
+        // TODO: define a way to sanitize ids
+        $comments_string = '(' . implode( ",", $comments_id ) . ')';
+        // Determine if a parent comment is being deleted from a comment that is not being deleted
+        $parents = $wpdb->get_results( "SELECT comment_parent FROM $wpdb->comments WHERE comment_parent IN $comments_string AND comment_ID NOT IN $comments_string" , ARRAY_N);
+        // Determine grandparents
+        if ( !empty( $parents ) ) {
+                // The next line doesn't work because is an associative arrays and we need only the values
+                $parents_string = '(' . implode( ",", $parents ) . ')';
+                $grandparents = $wpdb->get_results( "SELECT comment_parent FROM $wpdb->comments WHERE comment_ID NOT IN $parents_string", ARRAY_N );
+                // Determine very old ancestors
+                if ( !empty( $grandparents ) ) {
+                        $grandparents_string = '(' . implode( ",", $grandparents ) . ')';
+                        $ancestors = $wpdb->get_results( "SELECT comment_parent FROM $wpdb->comments WHERE comment_ID NOT IN $grandparents_string", ARRAY_N );
+                }
+        }
+
+        // TODO: Find grandfathers of this parents and do reparenting before delete them
+
+        foreach ( $comments_id as $comment_id ) {
+                $single_comment = wp_delete_comment( $comment_id, $force_delete, true );
+                if ( !$single_comment ) {
+                        return false;
+                }
+        }
+
+        /**
+         * Fires immediately after comments are deleted from the database.
+         *
+         * @since x.x.x
+         *
+         * @param int        $comment_id The comment ID.
+         */
+        do_action( 'deleted_comments', $comments_id );
+        return true;
+}
+
 /**
  * Moves a comment to the Trash
  *

src/wp-includes/post.php

@@ -3003 +3003 @@
 
         wp_defer_comment_counting( true );
 
-        $comment_ids = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_post_ID = %d", $postid ) );
-        foreach ( $comment_ids as $comment_id ) {
-                wp_delete_comment( $comment_id, true );
-        }
+        $comment_ids = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_post_ID = %d ORDER BY comment_ID DESC", $postid ) );
+        wp_delete_comments( $comment_ids, true );
 
         wp_defer_comment_counting( false );
 
@@ -5610 +5608 @@
         wp_defer_comment_counting( true );
 
         $comment_ids = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_post_ID = %d", $post_id ) );
-        foreach ( $comment_ids as $comment_id ) {
-                wp_delete_comment( $comment_id, true );
-        }
+        wp_delete_comments( $comment_ids, true );
 
         wp_defer_comment_counting( false );
 

tests/phpunit/tests/comment/query.php

@@ -4381 +4381 @@
                 $this->assertEqualSets( array( $c ), $found );
         }
 
+        /**
+         * @ticket 37703
+         */
+        public function test_delete_comments() {
+                $parent1 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                        )
+                );
+
+                $parent2 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $parent1,
+                        )
+                );
+
+                $c1 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $parent2,
+                        )
+                );
+
+                $c2 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $parent2,
+                        )
+                );
+
+                $c3 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $c2,
+                        )
+                );
+
+                $parent3 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                        )
+                );
+
+                $c4 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $parent3,
+                        )
+                );
+
+                self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $c4,
+                        )
+                );
+
+                $c5 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                        )
+                );
+
+                self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $c5,
+                        )
+                );
+
+                $c6 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                        )
+                );
+
+                $c7 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $c6,
+                        )
+                );
+
+                self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_approved' => '1',
+                                'comment_parent'   => $c7,
+                        )
+                );
+
+                $this->assertTrue( wp_delete_comments( array( $c1, $c2, $c3, $c4, $c5, $c6, $c7 ) ) );
+        }
+
         public function test_comment_query_should_be_cached() {
                 global $wpdb;