Ticket #37746: 37746.diff

src/wp-includes/meta.php

@@ -571 +571 @@
                 return false;
         }
 
-        $meta_id = absint( $meta_id );
-        if ( ! $meta_id ) {
+        $meta_id = intval( $meta_id );
+        if ( $meta_id <= 0 ) {
                 return false;
         }
 
@@ -615 +615 @@
                 return false;
         }
 
-        $meta_id = absint( $meta_id );
-        if ( ! $meta_id ) {
+        $meta_id = intval( $meta_id );
+        if ( $meta_id <= 0 ) {
                 return false;
         }
 
@@ -706 +706 @@
                 return false;
         }
 
-        $meta_id = absint( $meta_id );
-        if ( ! $meta_id ) {
+        $meta_id = intval( $meta_id );
+        if ( $meta_id <= 0 ) {
                 return false;
         }
 

tests/phpunit/tests/meta.php

@@ -293 +293 @@
         }
 
         /**
+         * @ticket 37746
+         */
+        function test_negative_meta_id() {
+                $negative_mid = $this->meta_id * -1;
+
+                $this->assertTrue( $negative_mid < 0 );
+                $this->assertFalse( get_metadata_by_mid( 'user', $negative_mid ) );
+                $this->assertFalse( update_metadata_by_mid( 'user', $negative_mid, 'meta_new_value' ) );
+                $this->assertFalse( delete_metadata_by_mid( 'user', $negative_mid ) );
+        }
+
+        /**
          * @ticket 15030
          */
         public function test_get_metadata_with_empty_key_array_value() {