Ticket #37813: 37813.patch

src/wp-includes/post.php

@@ -4694 +4694 @@
  * setting the value for the 'comment_status' key.
  *
  * @since 2.0.0
- * @since 4.7.0 Add fourth paramater `$wp_error` to allow  return of WP_Error on failure.
  *
  * @see wp_insert_post()
  *
  * @param string|array $args   Arguments for inserting an attachment.
  * @param string       $file   Optional. Filename.
  * @param int          $parent Optional. Parent post ID.
- * @param bool  $wp_error Optional. Whether to allow return of WP_Error on failure. Default false.
- * @return int|WP_Error The attachment ID on success. The value 0 or WP_Error on failure.
+ * @return int Attachment ID.
  */
-function wp_insert_attachment( $args, $file = false, $parent = 0, $wp_error = false ) {
+function wp_insert_attachment( $args, $file = false, $parent = 0 ) {
         $defaults = array(
                 'file'        => $file,
                 'post_parent' => 0
@@ -4718 +4716 @@
 
         $data['post_type'] = 'attachment';
 
-        return wp_insert_post( $data, $wp_error );
+        return wp_insert_post( $data );
 }
 
 /**