Ticket #38211: 38211.6.diff

src/js/_enqueues/wp/updates.js

@@ -139 +139 @@
          */
         wp.updates.searchTerm = '';
 
+        /**
+         * Minimum number of characters before an ajax search is fired.
+         *
+         * @since 5.4.0
+         *
+         * @type {number}
+         */
+        wp.updates.searchMinCharacters = 2;
+
         /**
          * Whether filesystem credentials need to be requested from the user.
          *
@@ -2502 +2511 @@
                         $pluginInstallSearch.attr( 'aria-describedby', 'live-search-desc' );
                 }
 
+                // Track the previous search string length.
+                var previousSearchStringLength = 0;
+                wp.updates.shouldSearch = function( searchStringLength ) {
+                        var shouldSearch = searchStringLength >= wp.updates.searchMinCharacters ||
+                                previousSearchStringLength >= wp.updates.searchMinCharacters;
+                        previousSearchStringLength = searchStringLength;
+                        return shouldSearch;
+                };
+
                 /**
                  * Handles changes to the plugin search box on the new-plugin page,
                  * searching the repository dynamically.
@@ -2509 +2527 @@
                  * @since 4.6.0
                  */
                 $pluginInstallSearch.on( 'keyup input', _.debounce( function( event, eventtype ) {
-                        var $searchTab = $( '.plugin-install-search' ), data, searchLocation;
+                        var $searchTab = $( '.plugin-install-search' ), data, searchLocation,
+                                searchStringLength = $pluginInstallSearch.val().length;
 
                         data = {
                                 _ajax_nonce: wp.updates.ajaxNonce,
@@ -2520 +2539 @@
                         };
                         searchLocation = location.href.split( '?' )[ 0 ] + '?' + $.param( _.omit( data, [ '_ajax_nonce', 'pagenow' ] ) );
 
+                        // Set the autocomplete attribute, turning off autocomplete 1 character before ajax search kicks in.
+                        if ( wp.updates.shouldSearch( searchStringLength ) ) {
+                                $pluginInstallSearch.attr( 'autocomplete', 'off' );
+                        } else {
+                                $pluginInstallSearch.attr( 'autocomplete', 'on' );
+                                return;
+                        }
+
                         // Clear on escape.
                         if ( 'keyup' === event.type && 27 === event.which ) {
                                 event.target.value = '';
@@ -2579 +2606 @@
 
                 if ( $pluginSearch.length ) {
                         $pluginSearch.attr( 'aria-describedby', 'live-search-desc' );
+
                 }
 
                 /**
@@ -2594 +2622 @@
                                 pagenow:       pagenow,
                                 plugin_status: 'all'
                         },
-                        queryArgs;
+                        queryArgs,
+                        searchStringLength = $pluginSearch.val().length;
+
+                        // Set the autocomplete attribute, turning off autocomplete 1 character before ajax search kicks in.
+                        if ( wp.updates.shouldSearch( searchStringLength ) ) {
+                                $pluginSearch.attr( 'autocomplete', 'off' );
+                        } else {
+                                $pluginSearch.attr( 'autocomplete', 'on' );
+                                return;
+                        }
 
                         // Clear on escape.
                         if ( 'keyup' === event.type && 27 === event.which ) {

src/wp-includes/blocks/latest-comments.php

@@ -41 +41 @@
  * @return string Returns the post content with latest comments added.
  */
 function render_block_core_latest_comments( $attributes = array() ) {
+        // This filter is documented in wp-includes/widgets/class-wp-widget-recent-comments.php.
         $comments = get_comments(
-                // This filter is documented in wp-includes/widgets/class-wp-widget-recent-comments.php.
                 apply_filters(
                         'widget_comments_args',
                         array(