Ticket #38238: 38238.3.diff

src/wp-admin/includes/class-wp-comments-list-table.php

@@ -415 +415 @@
                 return array(
                         'author'   => 'comment_author',
                         'response' => 'comment_post_ID',
-                        'date'     => 'comment_date'
+                        'date'     => array(
+                                'query_var' => 'comment_date',
+                                'order'     => 'DESC',
+                        ),
                 );
         }
 

src/wp-admin/includes/class-wp-links-list-table.php

@@ -143 +143 @@
                         'name'    => 'name',
                         'url'     => 'url',
                         'visible' => 'visible',
-                        'rating'  => 'rating'
+                        'rating'  => array(
+                                'query_var' => 'rating',
+                                'order'     => 'DESC',
+                        ),
                 );
         }
 

src/wp-admin/includes/class-wp-list-table.php

@@ -1010 +1010 @@
                                 continue;
 
                         $data = (array) $data;
+
+                        if ( isset( $data['query_var'] ) ) {
+                                if ( !isset( $data['order'] ) )
+                                        $data['order'] = 'ASC';
+
+                                $data = array( $data['query_var'], ( $data['order'] == 'DESC' ) );
+                        }
+
                         if ( !isset( $data[1] ) )
                                 $data[1] = false;
 

src/wp-admin/includes/class-wp-media-list-table.php

@@ -329 +329 @@
          */
         protected function get_sortable_columns() {
                 return array(
-                        'title'    => 'title',
-                        'author'   => 'author',
-                        'parent'   => 'parent',
-                        'comments' => 'comment_count',
-                        'date'     => array( 'date', true ),
+                        'title'         => 'title',
+                        'author'        => 'author',
+                        'parent'        => 'parent',
+                        'comments'      => array( 
+                                'query_var' => 'comment_count',
+                                'order'     => 'DESC',
+                        ),
+                        'date'          => array( 
+                                'query_var' => 'date',
+                                'order'     => 'DESC',
+                        ),
                 );
         }
 

src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -188 +188 @@
          */
         protected function get_sortable_columns() {
                 return array(
-                        'username'   => 'login',
-                        'name'       => 'name',
-                        'email'      => 'email',
-                        'registered' => 'id',
+                        'username'      => 'login',
+                        'name'          => 'name',
+                        'email'         => 'email',
+                        'registered'    => array(
+                                'query_var' => 'registered',
+                                'order'     => 'DESC',
+                        ),
                 );
         }
 

src/wp-admin/includes/class-wp-posts-list-table.php

@@ -611 +611 @@
          */
         protected function get_sortable_columns() {
                 return array(
-                        'title'    => 'title',
-                        'parent'   => 'parent',
-                        'comments' => 'comment_count',
-                        'date'     => array( 'date', true )
+                        'title'         => 'title',
+                        'parent'        => 'parent',
+                        'comments'      => array( 
+                                'query_var' => 'comment_count',
+                                'order'     => 'DESC',
+                        ),
+                        'date'          => array(
+                                'query_var' => 'date',
+                                'order'     => 'DESC',
+                        ),
                 );
         }
 

src/wp-admin/includes/class-wp-terms-list-table.php

@@ -197 +197 @@
          */
         protected function get_sortable_columns() {
                 return array(
-                        'name'        => 'name',
-                        'description' => 'description',
-                        'slug'        => 'slug',
-                        'posts'       => 'count',
-                        'links'       => 'count'
+                        'name'          => 'name',
+                        'description'   => 'description',
+                        'slug'          => 'slug',
+                        'posts'         => array(
+                                'query_var' => 'count',
+                                'order'     => 'DESC',
+                        ),
+                        'links'         => array(
+                                'query_var' => 'count',
+                                'order'     => 'DESC',
+                        ),
                 );
         }