Ticket #38673: patch-38673-4.diff

src/wp-admin/includes/class-wp-automatic-updater.php

@@ -31 +31 @@
          */
         public function is_disabled() {
                 // Background updates are disabled if you don't want file changes.
-                if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS )
+                if ( wp_disallow_file_mods( 'automatic_updater' ) )
                         return true;
 
                 if ( wp_installing() )

src/wp-admin/includes/dashboard.php

@@ -1149 +1149 @@
                 )
         );
 
-        if ( ( ! defined( 'DISALLOW_FILE_MODS' ) || ! DISALLOW_FILE_MODS ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) || ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {
+        if ( ( ! wp_disallow_file_mods( 'dashboard_widget' ) ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) || ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {
                 $feeds['plugins'] = array(
                         'link'         => '',
                         'url'          => array(

src/wp-admin/includes/translation-install.php

@@ -181 +181 @@
                 return $download;
         }
 
-        if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+        if ( wp_disallow_file_mods( 'download_language_pack' ) ) {
                 return false;
         }
 
@@ -224 +224 @@
  * @return bool Returns true on success, false on failure.
  */
 function wp_can_install_language_pack() {
-        if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+        if ( wp_disallow_file_mods( 'can_install_language_pack' ) ) {
                 return false;
         }
 

src/wp-includes/capabilities.php

@@ -336 +336 @@
                 // Disallow the file editors.
                 if ( defined( 'DISALLOW_FILE_EDIT' ) && DISALLOW_FILE_EDIT )
                         $caps[] = 'do_not_allow';
-                elseif ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS )
+                elseif ( wp_disallow_file_mods( 'capability_edit_themes' ) )
                         $caps[] = 'do_not_allow';
                 elseif ( is_multisite() && ! is_super_admin( $user_id ) )
                         $caps[] = 'do_not_allow';
@@ -354 +354 @@
         case 'update_core':
                 // Disallow anything that creates, deletes, or updates core, plugin, or theme files.
                 // Files in uploads are excepted.
-                if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+                if ( wp_disallow_file_mods( 'capability_update_core' ) ) {
                         $caps[] = 'do_not_allow';
                 } elseif ( is_multisite() && ! is_super_admin( $user_id ) ) {
                         $caps[] = 'do_not_allow';

src/wp-includes/load.php

@@ -1064 +1064 @@
 function is_wp_error( $thing ) {
         return ( $thing instanceof WP_Error );
 }
+
+/**
+ * Determines whether file modifications are disallowed.
+ *
+ * @since 4.7.0
+ *
+ * @param string $context Where it has been called from.
+ * @return bool True if file modification is disallowed, False otherwise.
+ */
+function wp_disallow_file_mods( $context ) {
+        /**
+         * Filter the DISALLOW_FILE_MODS constant.
+         *
+         * @since 4.7.0
+         *
+         * @param bool $disllow_file_mods The DISALLOW_FILE_MODS value.
+         * @param string $context Where it has been called from.
+         */
+        return apply_filters( 'disallow_file_mods' , defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS, $context );
+}