Make WordPress Core

Ticket #38763: 38763.patch

File 38763.patch, 1.1 KB (added by johnjamesjacoby, 9 years ago)

Prevent overriding the $user string variable with a WP_User object

  • src/wp-includes/ms-functions.php

    diff --git src/wp-includes/ms-functions.php src/wp-includes/ms-functions.php
    index 3eb7f67..214cc3c 100644
     
    801801        $from_name = get_site_option( 'site_name' ) == '' ? 'WordPress' : esc_html( get_site_option( 'site_name' ) );
    802802        $message_headers = "From: \"{$from_name}\" <{$admin_email}>\n" . "Content-Type: text/plain; charset=\"" . get_option('blog_charset') . "\"\n";
    803803
    804         $user = get_user_by( 'login', $user );
    805         $switched_locale = switch_to_locale( get_user_locale( $user ) );
     804        $_user = get_user_by( 'login', $user );
     805        $switched_locale = switch_to_locale( get_user_locale( $_user ) );
    806806
    807807        $message = sprintf(
    808808                /**
     
    896896        if ( ! apply_filters( 'wpmu_signup_user_notification', $user, $user_email, $key, $meta ) )
    897897                return false;
    898898
    899         $user = get_user_by( 'login', $user );
    900         $switched_locale = switch_to_locale( get_user_locale( $user ) );
     899        $_user = get_user_by( 'login', $user );
     900        $switched_locale = switch_to_locale( get_user_locale( $_user ) );
    901901
    902902        // Send email with activation link.
    903903        $admin_email = get_site_option( 'admin_email' );