Ticket #38903: 38903.3.diff

src/wp-includes/option.php

@@ -296 +296 @@
         $value = apply_filters( 'pre_update_option', $value, $option, $old_value );
 
         // If the new and old values are the same, no need to update.
-        if ( $value === $old_value )
+        if ( maybe_serialize( $value ) === maybe_serialize( $old_value ) ) {
                 return false;
+        }
 
         /** This filter is documented in wp-includes/option.php */
         if ( apply_filters( 'default_option_' . $option, false, $option, false ) === $old_value ) {

tests/phpunit/tests/option/updateOption.php

@@ -166 +166 @@
         }
 
         /**
+         * @ticket 38903
+         */
+        public function test_update_option_array_with_object() {
+                $array_w_object = array(
+                        'url'       => 'http://src.wordpress-develop.dev/wp-content/uploads/2016/10/cropped-Blurry-Lights.jpg',
+                        'meta_data' => ( object ) array(
+                                'attachment_id' => 292,
+                                'height'        => 708,
+                                'width'         => 1260,
+                        )
+                );
+
+                // Add the option, it did not exist before this.
+                add_option( 'array_w_object', $array_w_object );
+
+                $num_queries_pre_update = get_num_queries();
+
+                // Update the option using the same array with an object for the value.
+                $this->assertFalse( update_option( 'array_w_object', $array_w_object ) );
+
+                // Check that no new database queries were performed.
+                $this->assertEquals( $num_queries_pre_update, get_num_queries() );
+        }
+
+        /**
          * `add_filter()` callback for test_should_respect_default_option_filter_when_option_does_not_yet_exist_in_database().
          */
         public function __return_foo() {