Ticket #38922: 38922.3.diff

src/wp-admin/includes/admin-filters.php

@@ -119 +119 @@
 add_action( 'upgrader_process_complete', 'wp_version_check', 10, 0 );
 add_action( 'upgrader_process_complete', 'wp_update_plugins', 10, 0 );
 add_action( 'upgrader_process_complete', 'wp_update_themes', 10, 0 );
+

src/wp-admin/includes/ajax-actions.php

@@ -101 +101 @@
 /**
  * Ajax handler for tag search.
  *
+ * @deprecated 4.8.0 Use the REST API tags endpoint instead.
+ *
  * @since 3.1.0
  */
 function wp_ajax_ajax_tag_search() {

src/wp-admin/js/tags-suggest.js

@@ -53 +53 @@
 
                                 term = getLast( request.term );
 
-                                $.get( window.ajaxurl, {
-                                        action: 'ajax-tag-search',
-                                        tax: taxonomy,
-                                        q: term
+                                $.get( window.tagsSuggestL10n.rest_url, {
+                                        taxonomy: taxonomy,
+                                        search: term,
+                                        'action': 'wp-post-tag-search'
                                 } ).always( function() {
                                         $element.removeClass( 'ui-autocomplete-loading' ); // UI fails to remove this sometimes?
                                 } ).done( function( data ) {
-                                        var tagName;
-                                        var tags = [];
-
-                                        if ( data ) {
-                                                data = data.split( '\n' );
-
-                                                for ( tagName in data ) {
-                                                        var id = ++tempID;
-
-                                                        tags.push({
-                                                                id: id,
-                                                                name: data[tagName]
-                                                        });
-                                                }
-
-                                                cache = tags;
-                                                response( tags );
-                                        } else {
-                                                response( tags );
-                                        }
+                                        cache = data;
+                                        response( data );
                                 } );
 
                                 last = request.term;
@@ -118 +100 @@
                         close: function() {
                                 $element.attr( 'aria-expanded', 'false' );
                         },
-                        minLength: 2,
+                        minLength: window.tagsSuggestL10n.minChars,
                         position: {
                                 my: 'left top+2'
                         },

src/wp-includes/post.php

@@ -6219 +6219 @@
 
         return $clauses;
 }
+
+/**
+ * Filter fields returned for the post edit tag search.
+ *
+ * @param WP_REST_Response  $response  The response object.
+ *
+ * @return WP_REST_Response $response The filtered response object.
+ */
+function wp_filter_tag_search_in_post_edit( $response ) {
+        return  array(
+                'id'=>   $response->data['id'],
+                'name'=> $response->data['name'],
+        );
+}

src/wp-includes/rest-api.php

@@ -172 +172 @@
         add_filter( 'rest_post_dispatch', 'rest_send_allow_header', 10, 3 );
 
         add_filter( 'rest_pre_dispatch', 'rest_handle_options_request', 10, 3 );
+
+        // Post tag search filter.
+        if ( isset( $_GET['action'] ) && 'wp-post-tag-search' === $_GET['action'] ) {
+                add_filter( 'rest_prepare_post_tag', 'wp_filter_tag_search_in_post_edit' );
+        }
 }
 
 /**

src/wp-includes/script-loader.php

@@ -547 +547 @@
                         'termSelected' => __( 'Term selected.' ),
                         'termAdded'    => __( 'Term added.' ),
                         'termRemoved'  => __( 'Term removed.' ),
+                        'rest_url'     => rest_url( '/wp/v2/tags' ),
+                        /**
+                         * Filters the minimum number of characters required to fire a tag search via Ajax.
+                         *
+                         * @since 4.0.0
+                         *
+                         * @param int         $characters The minimum number of characters required. Default 2.
+                         */
+                        'minChars'     => (int) apply_filters( 'term_search_min_chars', 2 ),
                 ) );
 
                 $scripts->add( 'post', "/wp-admin/js/post$suffix.js", array( 'suggest', 'wp-lists', 'postbox', 'tags-box', 'underscore', 'word-count', 'wp-a11y' ), false, 1 );