Ticket #38932: 38932.4.patch

src/wp-includes/js/media-views.js

@@ -4018 +4018 @@
 
                 if ( this.options.suggestedWidth && this.options.suggestedHeight ) {
                         this.toolbar.set( 'suggestedDimensions', new View({
-                                el: $( '<div class="instructions">' + l10n.suggestedDimensions + ' ' + this.options.suggestedWidth + ' &times; ' + this.options.suggestedHeight + '</div>' )[0],
+                                el: $( '<div class="instructions">' + l10n.suggestedDimensions.replace( '%1$s', this.options.suggestedWidth ).replace( '%2$s', this.options.suggestedHeight ) + '</div>' )[0],
                                 priority: -40
                         }) );
                 }

src/wp-includes/js/media/views/attachments/browser.js

@@ -287 +287 @@
 
                 if ( this.options.suggestedWidth && this.options.suggestedHeight ) {
                         this.toolbar.set( 'suggestedDimensions', new View({
-                                el: $( '<div class="instructions">' + l10n.suggestedDimensions + ' ' + this.options.suggestedWidth + ' &times; ' + this.options.suggestedHeight + '</div>' )[0],
+                                el: $( '<div class="instructions">' + l10n.suggestedDimensions.replace( '%1$s', this.options.suggestedWidth ).replace( '%2$s', this.options.suggestedHeight ) + '</div>' )[0],
                                 priority: -40
                         }) );
                 }

src/wp-includes/media-template.php

@@ -235 +235 @@
 
                                 <# if ( data.suggestedWidth && data.suggestedHeight ) { #>
                                         <p class="suggested-dimensions">
-                                                <?php _e( 'Suggested image dimensions:' ); ?> {{data.suggestedWidth}} &times; {{data.suggestedHeight}}
+                                                <?php
+                                                        /* translators: 1: a number of pixels wide, 2: a number of pixels tall */
+                                                        printf( __( 'Suggested image dimensions: %1$s by %2$s pixels' ), "{{data.suggestedWidth}}", "{{data.suggestedHeight}}" ); 
+                                                ?>
                                         </p>
                                 <# } #>
 

src/wp-includes/media.php

@@ -3483 +3483 @@
                 'cropImage' => __( 'Crop Image' ),
                 'cropYourImage' => __( 'Crop your image' ),
                 'cropping' => __( 'Cropping…' ),
-                'suggestedDimensions' => __( 'Suggested image dimensions:' ),
+                /* translators: 1: a number of pixels wide, 2: a number of pixels tall */
+                'suggestedDimensions' => __( 'Suggested image dimensions: %1$s by %2$s pixels' ),
                 'cropError' => __( 'There has been an error cropping your image.' ),
 
                 // Edit Audio