Ticket #38962: 38962.3.diff

src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php

@@ -701 +701 @@
          * @return WP_REST_Response|WP_Error Response object on success, or WP_Error object on failure.
          */
         public function delete_item( $request ) {
+                // We don't support delete requests in multisite.
+                if ( is_multisite() ) {
+                        return new WP_Error( 'rest_cannot_delete', __( 'The user cannot be deleted.' ), array( 'status' => 501 ) );
+                }
+
                 $id       = (int) $request['id'];
                 $reassign = false === $request['reassign'] ? null : absint( $request['reassign'] );
                 $force    = isset( $request['force'] ) ? (bool) $request['force'] : false;

tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -1643 +1643 @@
                 $request->set_param( 'reassign', false );
                 $response = $this->server->dispatch( $request );
 
+                // Not implemented in multisite.
+                if ( is_multisite() ) {
+                        $this->assertErrorResponse( 'rest_cannot_delete', $response, 501 );
+                        return;
+                }
+
                 $this->assertEquals( 200, $response->get_status() );
                 $data = $response->get_data();
                 $this->assertTrue( $data['deleted'] );
@@ -1660 +1666 @@
                 $request = new WP_REST_Request( 'DELETE', sprintf( '/wp/v2/users/%d', $user_id ) );
                 $request->set_param( 'reassign', false );
                 $response = $this->server->dispatch( $request );
+
+                // Not implemented in multisite.
+                if ( is_multisite() ) {
+                        $this->assertErrorResponse( 'rest_cannot_delete', $response, 501 );
+                        return;
+                }
+
                 $this->assertErrorResponse( 'rest_trash_not_supported', $response, 501 );
 
                 $request->set_param( 'force', 'false' );
@@ -1683 +1696 @@
                 $request->set_param( 'reassign', false );
                 $response = $this->server->dispatch( $request );
 
+                // Not implemented in multisite.
+                if ( is_multisite() ) {
+                        $this->assertErrorResponse( 'rest_cannot_delete', $response, 501 );
+                        return;
+                }
+
                 $this->assertEquals( 200, $response->get_status() );
                 $data = $response->get_data();
                 $this->assertTrue( $data['deleted'] );
@@ -1699 +1718 @@
                 $request = new WP_REST_Request( 'DELETE', '/wp/v2/users/me' );
                 $request->set_param( 'reassign', false );
                 $response = $this->server->dispatch( $request );
+
+                // Not implemented in multisite.
+                if ( is_multisite() ) {
+                        $this->assertErrorResponse( 'rest_cannot_delete', $response, 501 );
+                        return;
+                }
+
                 $this->assertErrorResponse( 'rest_trash_not_supported', $response, 501 );
 
                 $request->set_param( 'force', 'false' );
@@ -1740 +1766 @@
                 $request->set_param( 'reassign', false );
                 $response = $this->server->dispatch( $request );
 
+                // Not implemented in multisite.
+                if ( is_multisite() ) {
+                        $this->assertErrorResponse( 'rest_cannot_delete', $response, 501 );
+                        return;
+                }
+
                 $this->assertErrorResponse( 'rest_user_invalid_id', $response, 404 );
         }
 
@@ -1764 +1796 @@
                 $request->set_param( 'reassign', $reassign_id );
                 $response = $this->server->dispatch( $request );
 
+                // Not implemented in multisite.
+                if ( is_multisite() ) {
+                        $this->assertErrorResponse( 'rest_cannot_delete', $response, 501 );
+                        return;
+                }
+
                 $this->assertEquals( 200, $response->get_status() );
 
                 // Check that the post has been updated correctly
@@ -1782 +1820 @@
                 $request->set_param( 'reassign', 100 );
                 $response = $this->server->dispatch( $request );
 
+                // Not implemented in multisite.
+                if ( is_multisite() ) {
+                        $this->assertErrorResponse( 'rest_cannot_delete', $response, 501 );
+                        return;
+                }
+
                 $this->assertErrorResponse( 'rest_user_invalid_reassign', $response, 400 );
         }