Ticket #39057: 39057.diff

src/wp-admin/includes/file.php

@@ -1239 +1239 @@
                 $hidden_class = ' class="hidden"';
         }
 ?>
-<fieldset id="ssh-keys"<?php echo $hidden_class; ?>">
+<fieldset id="ssh-keys"<?php echo $hidden_class; ?>>
 <legend><?php _e( 'Authentication Keys' ); ?></legend>
 <label for="public_key">
         <span class="field-title"><?php _e('Public Key:') ?></span>

src/wp-admin/js/updates.js

@@ -1516 +1516 @@
          * @param {string} message Error message.
          */
         wp.updates.showErrorInCredentialsForm = function( message ) {
-                var $modal = $( '#request-filesystem-credentials-form' );
-
                 // Remove any existing error.
-                $modal.find( '.notice' ).remove();
-                $modal.find( '#request-filesystem-credentials-title' ).after( '<div class="notice notice-alt notice-error"><p>' + message + '</p></div>' );
+                $filesystemForm.find( '.notice' ).remove();
+                $filesystemForm.find( '#request-filesystem-credentials-title' ).after( '<div class="notice notice-alt notice-error"><p>' + message + '</p></div>' );
         };
 
         /**
@@ -1670 +1668 @@
         $( function() {
                 var $pluginFilter        = $( '#plugin-filter' ),
                         $bulkActionForm      = $( '#bulk-action-form' ),
+                        $filesystemForm      = $( '#request-filesystem-credentials-form' ),
                         $filesystemModal     = $( '#request-filesystem-credentials-dialog' ),
                         $pluginSearch        = $( '.plugins-php .wp-filter-search' ),
                         $pluginInstallSearch = $( '.plugin-install-php .wp-filter-search' );
@@ -1725 +1724 @@
                  *
                  * @since 4.2.0
                  */
-                $filesystemModal.on( 'change', 'input[name="connection_type"]', function() {
+                $filesystemForm.on( 'change', 'input[name="connection_type"]', function() {
                         $( '#ssh-keys' ).toggleClass( 'hidden', ( 'ssh' !== $( this ).val() ) );
                 } ).change();