Ticket #39087: 39087.1.diff

src/wp-admin/js/customize-widgets.js

@@ -1577 +1577 @@
                         api.Panel.prototype.ready.call( panel );
 
                         panel.deferred.embedded.done(function() {
-                                var panelMetaContainer, noRenderedAreasNotice, shouldShowNotice;
+                                var panelMetaContainer, noticeContainer, updateNotice, getActiveSectionCount, shouldShowNotice;
                                 panelMetaContainer = panel.container.find( '.panel-meta' );
-                                noRenderedAreasNotice = $( '<div></div>', {
+
+                                // @todo This should use the Notifications API introduced to panels. See <https://core.trac.wordpress.org/ticket/38794>.
+                                noticeContainer = $( '<div></div>', {
                                         'class': 'no-widget-areas-rendered-notice'
                                 });
-                                noRenderedAreasNotice.append( $( '<em></em>', {
-                                        text: l10n.noAreasRendered
-                                } ) );
-                                panelMetaContainer.append( noRenderedAreasNotice );
+                                panelMetaContainer.append( noticeContainer );
 
-                                shouldShowNotice = function() {
-                                        return ( 0 === _.filter( panel.sections(), function( section ) {
+                                /**
+                                 * Get the number of active sections in the panel.
+                                 *
+                                 * @return {number} Number of active sidebar sections.
+                                 */
+                                getActiveSectionCount = function() {
+                                        return _.filter( panel.sections(), function( section ) {
                                                 return section.active();
-                                        } ).length );
+                                        } ).length;
+                                };
+
+                                /**
+                                 * Determine whether or not the notice should be displayed.
+                                 *
+                                 * @return {boolean}
+                                 */
+                                shouldShowNotice = function() {
+                                        var activeSectionCount = getActiveSectionCount();
+                                        if ( 0 === activeSectionCount ) {
+                                                return true;
+                                        } else {
+                                                return activeSectionCount !== api.Widgets.data.registeredSidebars.length;
+                                        }
+                                };
+
+                                /**
+                                 * Update the notice.
+                                 *
+                                 * @returns {void}
+                                 */
+                                updateNotice = function() {
+                                        var activeSectionCount = getActiveSectionCount(), nonRenderedAreaCount, message = '';
+                                        noticeContainer.empty();
+
+                                        if ( 0 === activeSectionCount ) {
+                                                message = l10n.noAreasRendered;
+                                        } else if ( activeSectionCount !== api.Widgets.data.registeredSidebars.length ) {
+                                                nonRenderedAreaCount = api.Widgets.data.registeredSidebars.length - activeSectionCount;
+                                                if ( 1 === nonRenderedAreaCount ) {
+                                                        message = l10n.allAreasNotShown.singular.replace( '%d', nonRenderedAreaCount );
+                                                } else {
+                                                        message = l10n.allAreasNotShown.plural.replace( '%d', nonRenderedAreaCount );
+                                                }
+                                        }
+
+                                        if ( message ) {
+                                                noticeContainer.append( $( '<em></em>', {
+                                                        text: message
+                                                } ) );
+                                        }
                                 };
+                                updateNotice();
 
                                 /*
                                  * Set the initial visibility state for rendered notice.
                                  * Update the visibility of the notice whenever a reflow happens.
                                  */
-                                noRenderedAreasNotice.toggle( shouldShowNotice() );
+                                noticeContainer.toggle( shouldShowNotice() );
                                 api.previewer.deferred.active.done( function () {
-                                        noRenderedAreasNotice.toggle( shouldShowNotice() );
+                                        noticeContainer.toggle( shouldShowNotice() );
                                 });
                                 api.bind( 'pane-contents-reflowed', function() {
                                         var duration = ( 'resolved' === api.previewer.deferred.active.state() ) ? 'fast' : 0;
+                                        updateNotice();
                                         if ( shouldShowNotice() ) {
-                                                noRenderedAreasNotice.slideDown( duration );
+                                                noticeContainer.slideDown( duration );
                                         } else {
-                                                noRenderedAreasNotice.slideUp( duration );
+                                                noticeContainer.slideUp( duration );
                                         }
                                 });
                         });

src/wp-includes/class-wp-customize-widgets.php

@@ -733 +733 @@
                                 'widgetMovedUp'    => __( 'Widget moved up' ),
                                 'widgetMovedDown'  => __( 'Widget moved down' ),
                                 'noAreasRendered'  => __( 'There are no widget areas on the page shown, however other pages in this theme do have them.' ),
+                                /* translators: placeholder is the number of other widget areas registered */
+                                'allAreasNotShown' => wp_array_slice_assoc( _n_noop( 'There is %d other widget area registered for this theme but it is not shown on the current page.', 'There are %d other widgets area registered for this theme but they are not shown on the current page.' ), array( 'singular', 'plural' ) ),
                                 'reorderModeOn'    => __( 'Reorder mode enabled' ),
                                 'reorderModeOff'   => __( 'Reorder mode closed' ),
                                 'reorderLabelOn'   => esc_attr__( 'Reorder widgets' ),