Ticket #39211: 39211.2.patch

src/wp-includes/post-template.php

@@ -1631 +1631 @@
  * @return bool True on success, false on failure.
  */
 function is_page_template( $template = '' ) {
+        if ( ! is_singular() ) {
+                return false;
+        }
+
         $page_template = get_page_template_slug( get_queried_object_id() );
 
         if ( empty( $template ) )

tests/phpunit/tests/query/conditionals.php

@@ -22 +22 @@
                 update_option( 'comments_per_page', 5 );
                 update_option( 'posts_per_page', 5 );
 
+                create_initial_taxonomies();
                 $this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
-
-                create_initial_taxonomies();
         }
 
         function test_home() {
@@ -1074 +1073 @@
         }
 
         /**
+         * @ticket 39211
+         */
+        function test_is_page_template_not_singular() {
+                global $wpdb;
+
+                // We need an non-post that shares an ID with a post assigned a template.
+                $term_id = self::factory()->term->create();
+                if ( ! get_post( $term_id ) ) {
+                        $post_id = self::factory()->post->create( array( 'post_type' => 'post' ) );
+                        $wpdb->update( $wpdb->posts, array( 'ID' => $term_id ), array( 'ID' => $post_id ), array( '%d' ) );
+                }
+
+                update_post_meta( $term_id, '_wp_page_template', 'example.php' );
+
+                // Verify that the non-post with our ID does not report having a template.
+                $this->go_to( get_post_permalink( $term_id ) );
+                $this->assertTrue( is_page_template( 'example.php' ) );
+                $this->go_to( get_term_link( $term_id ) );
+                $this->assertInstanceOf( 'WP_Term', get_queried_object() ); // and not something else that would return false, like a 404.
+                $this->assertFalse( is_page_template( 'example.php' ) );
+        }
+
+        /**
          * @ticket 35902
          */
         public function test_is_attachment_should_not_match_numeric_id_to_post_title_beginning_with_id() {

tests/phpunit/tests/query/verboseRewriteRules.php

@@ -10 +10 @@
         function setUp() {
                 parent::setUp();
 
+                create_initial_taxonomies();
                 $this->set_permalink_structure( '/%category%/%year%/%postname%/' );
-                create_initial_taxonomies();
         }
 }