Ticket #39251: 39251.patch

src/wp-includes/general-template.php

@@ -3360 +3360 @@
         }
         $current  = (int) $args['current'];
         $end_size = (int) $args['end_size']; // Out of bounds?  Make it the default.
-        if ( $end_size < 1 ) {
+        if ( $end_size < 0 ) {
                 $end_size = 1;
         }
         $mid_size = (int) $args['mid_size'];
@@ -3388 +3388 @@
                  */
                 $page_links[] = '<a class="prev page-numbers" href="' . esc_url( apply_filters( 'paginate_links', $link ) ) . '">' . $args['prev_text'] . '</a>';
         endif;
+
+        if( 0 === $end_size && ! $args['show_all'] ) {
+                $dots = true;
+        }
+
         for ( $n = 1; $n <= $total; $n++ ) :
                 if ( $n == $current ) :
                         $page_links[] = "<span aria-current='" . esc_attr( $args['aria_current'] ) . "' class='page-numbers current'>" . $args['before_page_number'] . number_format_i18n( $n ) . $args['after_page_number'] . "</span>";

tests/phpunit/tests/general/paginateLinks.php

@@ -321 +321 @@
                 $page_2_url = home_url() . '?foo=2';
                 $this->assertContains( "<a class='page-numbers' href='$page_2_url'>2</a>", $links );
         }
+
+        /**
+         * @ticket 39251
+         */
+        public function test_paginate_links_should_support_zero_end_size() {
+
+                $links = paginate_links( array(
+                        'total'         => 10,
+                        'current'       => 5,
+                        'mid_size'      => 1,
+                        'end_size'      => 0,
+                        'type'          => 'array',
+                ) );
+
+                $this->assertSame( '<span class="page-numbers dots">&hellip;</span>', $links[1] );
+                $this->assertSame( '<span class="page-numbers dots">&hellip;</span>', $links[5] );
+        }
 }