Ticket #39309: 39309-tests.diff

.travis.yml

@@ -12 +12 @@
     - WP_TRAVISCI=travis:phpunit
 matrix:
   include:
+  - php: 7.3
+    env: WP_TRAVISCI=travis:phpunit:upgrade
   - php: 7.2
     env: WP_TRAVISCI=travis:format
   - php: 7.1
@@ -33 +35 @@
   fast_finish: true
 before_install:
 - |
-  if [[ "$WP_TRAVISCI" == "travis:phpunit" ]]; then
+  if [[ "$WP_TRAVISCI" == travis:phpunit* ]]; then
       mysql -u root -e "CREATE DATABASE wordpress_tests;"
       cp wp-tests-config-sample.php wp-tests-config.php
       sed -i "s/youremptytestdbnamehere/wordpress_tests/" wp-tests-config.php
@@ -60 +62 @@
   export PATH=`composer config --list --global | grep '\[home\]' | { read a; echo "${a#* }/vendor/bin:$PATH"; }`
 - |
   # Install the specified version of PHPUnit depending on the PHP version:
-  if [[ "$WP_TRAVISCI" == "travis:phpunit" ]]; then
+  if [[ "$WP_TRAVISCI" == travis:phpunit* ]]; then
     case "$TRAVIS_PHP_VERSION" in
       7.4snapshot|7.3|7.2|7.1|nightly)
         echo "Using PHPUnit 7.x"

Gruntfile.js

@@ -666 +666 @@
                                 args: ['--verbose', '-c', 'phpunit.xml.dist', '--group', 'restapi-jsclient']
                         }
                 },
+                travis_phpunit_upgrade: {
+                        'default' : {
+                                cmd: 'phpunit',
+                                args: [ '--verbose', '-c', 'phpunit.xml.dist', '--group', 'upgrade-tests' ]
+                        }
+                },
                 uglify: {
                         options: {
                                 ASCIIOnly: true,
@@ -1407 +1413 @@
                 }, this.async());
         });
 
+        grunt.registerMultiTask('travis_phpunit_upgrade', 'Runs Upgrade PHPUnit tests.', function() {
+                grunt.util.spawn({
+                        cmd: this.data.cmd,
+                        args: this.data.args,
+                        opts: {stdio: 'inherit'}
+                }, this.async());
+        });
+
         grunt.registerTask('qunit:compiled', 'Runs QUnit tests on compiled as well as uncompiled scripts.',
                 ['build', 'copy:qunit', 'qunit']);
 
@@ -1433 +1447 @@
         // Travis CI tasks.
         grunt.registerTask('travis:js', 'Runs Javascript Travis CI tasks.', [ 'jshint:corejs', 'qunit:compiled' ]);
         grunt.registerTask('travis:phpunit', 'Runs PHPUnit Travis CI tasks.', [ 'build', 'phpunit' ]);
+        grunt.registerTask('travis:phpunit:upgrade', 'Runs Upgrade PHPUnit Travis CI tasks.', [ 'build', 'travis_phpunit_upgrade' ]);
         grunt.registerTask('travis:format', 'Runs Code formatting Travis CI tasks.', [ 'format:php:error' ]);
 
         // Patch task.

phpunit.xml.dist

@@ -31 +31 @@
                         <group>ms-files</group>
                         <group>ms-required</group>
                         <group>external-http</group>
+                        <group>upgrade-tests</group>
                 </exclude>
         </groups>
         <logging>

tests/phpunit/includes/bootstrap.php

@@ -145 +145 @@
 require dirname( __FILE__ ) . '/testcase-xmlrpc.php';
 require dirname( __FILE__ ) . '/testcase-ajax.php';
 require dirname( __FILE__ ) . '/testcase-canonical.php';
+require dirname( __FILE__ ) . '/testcase-upgrade.php';
 require dirname( __FILE__ ) . '/exceptions.php';
 require dirname( __FILE__ ) . '/utils.php';
 require dirname( __FILE__ ) . '/spy-rest-server.php';
 require dirname( __FILE__ ) . '/class-wp-rest-test-search-handler.php';
 require dirname( __FILE__ ) . '/class-wp-fake-block-type.php';
+require dirname( __FILE__ ) . '/class-wp-tests-upgrader-skin.php';
 
 /**
  * A class to handle additional command line arguments passed to the script.
@@ -168 +170 @@
                         'ajax'          => true,
                         'ms-files'      => true,
                         'external-http' => true,
+                        'upgrade-tests' => true,
                 );
 
                 while ( current( $argv ) ) {

new file tests/phpunit/includes/class-wp-tests-upgrader-skin.php

@@ +1 @@
+<?php
+
+require_once( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
+
+class WP_Tests_Upgrader_Skin extends Automatic_Upgrader_Skin {
+        function header() {}
+        function footer() {}
+        // Assume it's all fine and dandy when we're running in tests. We're not testing Filesystem access afterall.
+        function request_filesystem_credentials( $error = false, $context = '', $allow_relaxed_file_ownership = false ) {
+                return true;
+        }
+}

new file tests/phpunit/includes/testcase-upgrade.php

@@ +1 @@
+<?php
+
+abstract class WP_Upgrader_UnitTestCase extends WP_UnitTestCase {
+
+        // This might not actually install the plugin, as it may already exist.
+        // We're not interested in actually installing the plugin though, just the steps prior to the install.
+        function install_plugin_and_return_messages( $plugin_slug ) {
+                include_once( ABSPATH . 'wp-admin/includes/plugin-install.php' ); // For plugins_api()
+
+                if ( preg_match( '!^https?://!i', $plugin_slug ) ) {
+                        // The $plugin_slug looked like a URL, so we'll install that.
+                        $package_url = $plugin_slug;
+                } else {
+                        $api = plugins_api( 'plugin_information', array( 'slug' => $plugin_slug ) );
+                        // Temporary error
+                        if ( is_wp_error( $api ) ) {
+                                wp_die( $api );
+                        }
+                        $package_url = $api->download_link;
+                }
+
+                $skin     = new WP_Tests_Upgrader_Skin();
+                $upgrader = new Plugin_Upgrader( $skin );
+                $upgrader->install( $package_url );
+
+                return $skin->get_upgrade_messages();
+        }
+
+        // TODO Filter - Ensure that all requests to WordPress.org include the nostats parameter.
+
+        // Filter - Ensure WordPress has a single invalid key.
+        function filter_wp_trusted_keys_only_invalid_key() {
+                return array(
+                        $this->helper_random_public_key(),
+                );
+        }
+        // Filter - Prefix a random key to WordPress's existing keys.
+        function filter_wp_trusted_keys_prefix_invalid_key( $keys ) {
+                return array_merge(
+                        array( $this->helper_random_public_key() ),
+                        $keys
+                );
+        }
+        // Helper - Generate a new random public key.
+        function helper_random_public_key() {
+                static $key = false;
+                if ( $key ) {
+                        return $key;
+                }
+
+                // Generate a new key.
+                $random_keypair    = sodium_crypto_sign_keypair();
+                $random_public_key = sodium_crypto_sign_publickey( $random_keypair );
+                return base64_encode( $random_public_key );
+        }
+}

tests/phpunit/multisite.xml

@@ -40 +40 @@
                         <group>ms-excluded</group>
                         <group>external-http</group>
                         <group>oembed-headers</group>
+                        <group>upgrade-tests</group>
                 </exclude>
         </groups>
         <listeners>

new file tests/phpunit/tests/upgrade/plugins.php

@@ +1 @@
+<?php
+
+class Plugin_Upgrader_Tests extends WP_Upgrader_UnitTestCase {
+        /**
+         * Integration test - Install a plugin, make sure it succeeds.
+         * @group upgrade-tests
+         */
+        function test_install_plugin_hello_dolly() {
+                $messages = $this->install_plugin_and_return_messages( 'hello-dolly' );
+                $this->assertContains( 'Plugin installed successfully.', $messages );
+
+                /*
+                foreach ( $messages as $message ) {
+                        // TODO: This is a bit fragile and has to be kept in sync with verify_file_signature(), and needs to be enabled for all plugins first.
+                        $this->assertNotContains( 'could not be verified', $message );
+                }
+                */
+
+                // Now install it again, it should fail.
+                $messages = $this->install_plugin_and_return_messages( 'hello-dolly' );
+                $this->assertNotContains( 'Plugin installed successfully.', $messages );
+        }
+
+        /**
+         * Integration test - Install a plugin, make sure it succeeds.
+         * @group upgrade-tests
+         */
+        function test_install_plugin_hello_dolly_signing_failure() {
+
+                add_filter( 'wp_trusted_keys', array( $this, 'filter_wp_trusted_keys_only_invalid_key' ) );
+
+                // We don't care if this installation succeeds, we just need to get to the 'downloading' phase which is before it bails because it's already installed.
+                $messages = $this->install_plugin_and_return_messages( 'hello-dolly' );
+
+                remove_filter( 'wp_trusted_keys', array( $this, 'filter_wp_trusted_keys_only_invalid_key' ) );
+
+                $signing_failed = false;
+                foreach ( $messages as $message ) {
+                        $signing_failed = $signing_failed || ( false !== stripos( $message, 'could not be verified' ) );
+                }
+
+                $this->assertTrue( $signing_failed );
+        }
+
+        /**
+         * Integration test - Install a plugin, make sure it succeeds.
+         * @group upgrade-tests
+         */
+        function test_install_plugin_hello_dolly_add_bad_key() {
+                $this->markTestSkipped( 'Plugins do not yet have signatures.' );
+
+                add_filter( 'wp_trusted_keys', array( $this, 'filter_wp_trusted_keys_prefix_invalid_key' ) );
+
+                // We don't care if this installation succeeds, we just want to make sure that
+                $messages = $this->install_plugin_and_return_messages( 'hello-dolly' );
+
+                remove_filter( 'wp_trusted_keys', array( $this, 'filter_wp_trusted_keys_prefix_invalid_key' ) );
+
+                // There should be NO update strings which mention failures, if this plugin has signatures available.
+                foreach ( $messages as $message ) {
+                        // TODO: This is a bit fragile and has to be kept in sync with verify_file_signature()
+                        $this->assertNotContains( 'could not be verified', $message );
+                }
+        }
+
+        /**
+         * Integration test - Install a plugin from Github, make sure it succeeds.
+         * @group upgrade-tests
+         */
+        function test_install_plugin_github_wordpress_importer() {
+                $messages = $this->install_plugin_and_return_messages( 'https://github.com/WordPress/wordpress-importer/archive/master.zip' );
+
+                $this->assertContains( 'Plugin installed successfully.', $messages );
+
+                foreach ( $messages as $message ) {
+                        // TODO: This is a bit fragile and has to be kept in sync with verify_file_signature()
+                        $this->assertNotContains( 'could not be verified', $message );
+                }
+        }
+
+        /**
+         * Integration test - Install a plugin, check updates pass.
+         * @group upgrade-tests
+         */
+        function test_update_plugin_hello_dolly() {
+                $hello_dolly = WP_PLUGIN_DIR . '/hello-dolly/hello.php';
+                // If the plugins already installed from another test, save some time.
+                if ( ! file_exists( $hello_dolly ) ) {
+                        $messages = $this->install_plugin_and_return_messages( 'hello-dolly' );
+                        $this->assertContains( 'Plugin installed successfully.', $messages );
+                }
+
+                // Lower the version string of the plugin..
+                $contents = file_get_contents( $hello_dolly );
+                $contents = preg_replace_callback(
+                        '!^([\s*]*Version:\s*)([\d.]+)$!im',
+                        function( $m ) {
+                                return $m[1] . ( floatval( $m[2] ) - 0.1 );
+                        },
+                        $contents
+                );
+                file_put_contents( $hello_dolly, $contents );
+
+                // Get the update..
+                wp_update_plugins();
+
+                $skin     = new WP_Tests_Upgrader_Skin();
+                $upgrader = new Plugin_Upgrader( $skin );
+                $result   = $upgrader->upgrade(
+                        plugin_basename( $hello_dolly )
+                );
+
+                $messages = $skin->get_upgrade_messages();
+
+                $this->assertTrue( $result );
+                $this->assertContains( 'Plugin updated successfully.', $messages );
+
+                /*
+                foreach ( $messages as $message ) {
+                        // TODO: This is a bit fragile and has to be kept in sync with verify_file_signature(), and needs to be enabled for all plugins first.
+                        $this->assertNotContains( 'could not be verified', $message );
+                }
+                */
+
+        }
+
+        function tearDown() {
+                delete_plugins(
+                        [
+                                'hello-dolly/hello.php',
+                                'wordpress-importer-master/wordpress-importer.php',
+                        ]
+                );
+        }
+}

new file tests/phpunit/tests/upgrade/zz-core.php

@@ +1 @@
+<?php
+
+// Note: This file is named 'zz-core.php' in an attempt to run it last within travis runs of this group.
+// There's surely a better way, but this solves it for now.
+
+class Core_Upgrader_Tests extends WP_Upgrader_UnitTestCase {
+        /**
+         * Integration test - Test a reinstall of WordPress.
+         * @group upgrade-tests
+         */
+        function test_core_reinstall() {
+                if ( ! getenv( 'WP_TRAVISCI' ) ) {
+                        $this->markTestSkipped( "We don't appear to be running in a travis environment." );
+                }
+
+                // $skin will get first few update messages, and then they'll be available through `update_feedback` instead.
+                $skin = new WP_Tests_Upgrader_Skin();
+                add_filter( 'update_feedback', [ $skin, 'feedback' ], 0, 1 );
+
+                wp_version_check();
+                // Assume that the first upgrade included is either development, or latest.
+                $update = get_site_transient( 'update_core' )->updates[0];
+
+                WP_Filesystem( [], ABSPATH, true );
+                $upgrader = new Core_Upgrader( $skin );
+                $result   = $upgrader->upgrade(
+                        $update,
+                        array(
+                                'allow_relaxed_file_ownership' => true,
+                        )
+                );
+
+                remove_filter( 'update_feedback', [ $skin, 'feedback' ], 1 );
+
+                $messages = $skin->get_upgrade_messages();
+                foreach ( $messages as $message ) {
+                        // TODO: This is a bit fragile and has to be kept in sync with verify_file_signature()
+                        $this->assertNotContains( 'could not be verified', $message );
+                }
+
+                // $result is the new version on success
+
+                $this->assertNotWPError( $result );
+                $this->assertNotFalse( $result );
+                $this->assertGreaterThanOrEqual( 1, did_action( '_core_updated_successfully' ) );
+
+        }
+}