Ticket #39428: 39428.diff

src/wp-includes/class-wp-query.php

@@ -2121 +2121 @@
                         }
                         $q['author_name'] = sanitize_title_for_query( $q['author_name'] );
                         $q['author'] = get_user_by('slug', $q['author_name']);
-                        if ( $q['author'] )
+                        if ( $q['author'] ) {
                                 $q['author'] = $q['author']->ID;
-                        $whichauthor .= " AND ({$wpdb->posts}.post_author = " . absint($q['author']) . ')';
+                                $whichauthor .= " AND ({$wpdb->posts}.post_author = " . absint($q['author']) . ')';
+                        } else {
+                                $whichauthor .= " AND 1=0";
+                        }
                 }
 
                 // MIME-Type stuff for attachment browsing

tests/phpunit/tests/query/results.php

@@ -704 +704 @@
                 $feed_comment = $this->q->next_comment();
                 $this->assertEquals( $comment_id, $feed_comment->comment_ID );
         }
+
+        /**
+         * @ticket 39428
+         */
+        public function test_nonexisting_author_slug() {
+                self::factory()->post->create( array( 'post_author' => 1 ) );
+
+                $posts = $this->q->query( array( 'author_name' => 'admin' ) );
+
+                $this->assertNotEmpty( $posts );
+                $this->assertNotRegExp( '#AND 1=0#', $this->q->request );
+
+                $posts2 = $this->q->query( array( 'author_name' => 'noadmin' ) );
+                
+                $this->assertEmpty( $posts2 );
+                $this->assertRegExp( '#AND 1=0#', $this->q->request );
+        }
 }