Ticket #39494: 39494.2.diff

src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -272 +272 @@
                         $tax_exclude = $base . '_exclude';
 
                         if ( ! empty( $request[ $base ] ) ) {
+                                if ( isset( $request[ $base ]['ids'] ) ) {
+                                        $terms = $request[ $base ]['ids'];
+                                } else {
+                                        $terms = $request[ $base ];
+                                }
+
+                                if ( isset( $request[ $base ]['include_children'] ) ) {
+                                        $include_children = $request[ $base ]['include_children'];
+                                } else {
+                                        $include_children = false;
+                                }
+
                                 $query_args['tax_query'][] = array(
                                         'taxonomy'         => $taxonomy->name,
                                         'field'            => 'term_id',
-                                        'terms'            => $request[ $base ],
-                                        'include_children' => false,
+                                        'terms'            => $terms,
+                                        'include_children' => $include_children,
                                 );
                         }
 
@@ -2223 +2235 @@
                         $query_params[ $base ] = array(
                                 /* translators: %s: taxonomy name */
                                 'description' => sprintf( __( 'Limit result set to all items that have the specified term assigned in the %s taxonomy.' ), $base ),
-                                'type'        => 'array',
-                                'items'       => array(
-                                        'type' => 'integer',
+                                'type'        => 'object',
+                                'properties'  => array(
+                                        'ids'              => array(
+                                                'description' => __( 'The term ids to limit the post to' ),
+                                                'type'        => 'array',
+                                                'items'       => array(
+                                                        'type' => 'integer',
+                                                ),
+                                                'default'     => array(),
+                                        ),
+                                        'include_children' => array(
+                                                'description' => __( 'Whether or not to include the term children' ),
+                                                'type'        => 'boolean',
+                                                'default'     => false,
+                                        ),
                                 ),
-                                'default'     => array(),
                         );
 
                         $query_params[ $base . '_exclude' ] = array(

tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -934 +934 @@
                 $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
         }
 
+        /**
+         * Testing updated taxonomy schema and including category children.
+         *
+         * @ticket 39494
+         */
+        public function test_get_items_categories_with_updated_taxonomy_schema_and_include_children_true() {
+                $id1 = self::$post_id;
+                $id2 = $this->factory->post->create( array( 'post_status' => 'publish' ) );
+                $id3 = $this->factory->post->create( array( 'post_status' => 'publish' ) );
+
+                $cat1 = wp_insert_term( 'My Parent Category', 'category' );
+                $cat2 = wp_insert_term( 'My Child Category', 'category', array( 'parent' => $cat1['term_id'] ) );
+
+                wp_set_object_terms( $id1, array( $cat1['term_id'] ), 'category' );
+                wp_set_object_terms( $id2, array( $cat2['term_id'] ), 'category' );
+
+                $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+                $request->set_param( 'categories', array(
+                        'ids'              => array( $cat1['term_id'] ),
+                        'include_children' => true,
+                ) );
+                $response = rest_get_server()->dispatch( $request );
+                $data     = $response->get_data();
+
+                $this->assertCount( 2, $data );
+                $this->assertEquals( $id1, $data[0]['id'] );
+                $this->assertEquals( $id2, $data[1]['id'] );
+        }
+
+        /**
+         * Testing updated taxonomy schema without including category children.
+         *
+         * @ticket 39494
+         */
+        public function test_get_items_categories_with_updated_taxonomy_schema_and_include_children_false() {
+                $id1 = self::$post_id;
+                $id2 = $this->factory->post->create( array( 'post_status' => 'publish' ) );
+                $id3 = $this->factory->post->create( array( 'post_status' => 'publish' ) );
+
+                $cat1 = wp_insert_term( 'My Parent Category', 'category' );
+                $cat2 = wp_insert_term( 'My Child Category', 'category', array( 'parent' => $cat1['term_id'] ) );
+
+                wp_set_object_terms( $id1, array( $cat1['term_id'] ), 'category' );
+                wp_set_object_terms( $id2, array( $cat2['term_id'] ), 'category' );
+
+                $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+                $request->set_param( 'categories', array(
+                        'ids'              => array( $cat1['term_id'] ),
+                        'include_children' => false,
+                ) );
+                $response = rest_get_server()->dispatch( $request );
+                $data     = $response->get_data();
+
+                $this->assertCount( 1, $data );
+                $this->assertEquals( $id1, $data[0]['id'] );
+        }
+
         public function test_get_items_sticky() {
                 $id1 = self::$post_id;
                 $id2 = $this->factory->post->create( array( 'post_status' => 'publish' ) );