Ticket #39625: 39625.diff

wp-admin/includes/ajax-actions.php

@@ -2416 +2416 @@
                 wp_die();
         }
 
-        echo wp_json_encode(
-                array(
-                        'success' => true,
-                        'data'    => $attachment,
-                )
-        );
+  /**
+   * Ajax handler check set as featured image or not
+   * if set as featured image and set as doc. file then it's return error. 
+   * 
+   * @since 5.3.0
+   */ 
+  $success = true; 
 
+  if(isset($_REQUEST['action']) && $_REQUEST['action'] == 'upload-attachment' && isset($_REQUEST['is_featured']) && $_REQUEST['is_featured'] == 'true' && isset($attachment['type']) && $attachment['type'] != 'image'){
+    
+    $success = false;
+    $attachment = array(
+          'message'  => __( 'The uploaded file is not a valid image. Please select valid file format.' ),
+          'filename' => $_FILES['async-upload']['name'],
+        );
+
+  }
+
+  echo wp_json_encode(
+    array(
+      'success' => $success,
+      'data'    => $attachment,
+    )
+  );
+ 
         wp_die();
 }
 

wp-includes/js/media-editor.js

@@ -693 +693 @@
 
                         wp.media.featuredImage.set( selection ? selection.id : -1 );
                 },
+
                 /**
                  * Open the content media manager to the 'featured image' tab when
                  * the post thumbnail is clicked.
@@ -700 +701 @@
                  * Update the featured image id when the 'remove' link is clicked.
                  */
                 init: function() {
-                        $('#postimagediv').on( 'click', '#set-post-thumbnail', function( event ) {
+
+      $(document).on('click', '.editor-post-featured-image__toggle', function(){
+         _wpPluploadSettings.defaults.multipart_params['is_featured'] = true; 
+      });
+
+      $(document).on('click', '.editor-media-placeholder__button', function(){
+         _wpPluploadSettings.defaults.multipart_params['is_featured'] = false; 
+      });
+
+                        $('#postimagediv').on( 'click', '#set-post-thumbnail, .editor-post-featured-image__toggle', function( event ) {
+        _wpPluploadSettings.defaults.multipart_params['is_featured'] = true; 
                                 event.preventDefault();
                                 // Stop propagation to prevent thickbox from activating.
                                 event.stopPropagation();
@@ -778 +789 @@
                  * @returns {wp.media.view.MediaFrame.Select} A media workflow.
                  */
                 add: function( id, options ) {
+        
+      /**
+       * Check upload media is not a featured image
+       *
+       **/
+         
+       _wpPluploadSettings.defaults.multipart_params['is_featured'] = false;
+
                         var workflow = this.get( id );
 
                         // only add once: if exists return existing