Ticket #39667: 39667-2.diff

src/wp-includes/functions.php

@@ -274 +274 @@
 }
 
 /**
+ * Function will return duration/ file length in human readable format.
+ * This will be used for making readable string from duration.
+ * @since 4.8
+ * @param string $filelength duration will be in string format (HH:ii:ss) OR (ii:ss).
+ * @return boolean | string return human readable string, false otherwise. 
+ */
+function duration_format( $filelength='' ){
+    // return false if filelenght is enmpty
+    if( empty( $filelength ) ){
+        
+        return false;
+    }
+    
+    $human_readable_duration=false;
+    
+    // extract hour minutes and seconds
+    list ($second, $minute, $hour) = array_reverse ( explode ( ':', $filelength ) );
+    
+    if( !empty( $hour ) ){
+        /* translators: Time duration in hour or hours*/ 
+        $human_readable_duration .= sprintf( _n( '%s hour', '%s hours', $hour ), $hour ).' ';
+    }
+    
+    if( !empty( $minute) ){
+        /* translators: Time duration in minute or minutes*/ 
+        $human_readable_duration .= sprintf( _n( '%s minute', '%s minutes', $minute ), $minute ).' ';
+    }
+    
+    if( !empty( $second ) ){
+        /* translators: Time duration in second or seconds*/ 
+        $human_readable_duration .= sprintf( _n( '%s second', '%s seconds', $second ), $second );
+    }
+    // return human readable duration
+    return $human_readable_duration;
+  
+}
+
+/**
  * Get the week start and end from the datetime or date string from MySQL.
  *
  * @since 0.71

src/wp-includes/media-template.php

@@ -344 +344 @@
                                 <div class="file-size"><strong><?php _e( 'File size:' ); ?></strong> {{ data.filesizeHumanReadable }}</div>
                                 <# if ( 'image' === data.type && ! data.uploading ) { #>
                                         <# if ( data.width && data.height ) { #>
-                                                <div class="dimensions"><strong><?php _e( 'Dimensions:' ); ?></strong> {{ data.width }} &times; {{ data.height }}</div>
+                                                <div class="dimensions"><strong><?php _e( 'Dimensions:' ); ?></strong> 
+                                                    <?php
+                                                        /* translators: 1: a number of pixels wide, 2: a number of pixels tall */ 
+                                                        printf( __( '%1$s by %2$s pixels' ),'{{ data.width }}', '{{ data.height }}' );
+                                                    ?>
+                                                </div>
                                         <# } #>
                                 <# } #>
 
                                 <# if ( data.fileLength ) { #>
-                                        <div class="file-length"><strong><?php _e( 'Length:' ); ?></strong> {{ data.fileLength }}</div>
+                                        <div class="file-length"><strong><?php _e( 'Length:' ); ?></strong> 
+                                            <span aria-label="{{ data.fileLengthHumanReadable }}">{{ data.fileLength }}</span>
+                                        </div>
                                 <# } #>
 
                                 <# if ( 'audio' === data.type && data.meta.bitrate ) { #>

src/wp-includes/media.php

@@ -3219 +3219 @@
         }
 
         if ( $meta && ( 'audio' === $type || 'video' === $type ) ) {
-                if ( isset( $meta['length_formatted'] ) )
-                        $response['fileLength'] = $meta['length_formatted'];
+                if ( isset( $meta['length_formatted'] ) ){
+                        $response['fileLength']              = $meta['length_formatted'];
+                       $response['fileLengthHumanReadable'] = duration_format( $meta['length_formatted'] );
+                }    
 
                 $response['meta'] = array();
                 foreach ( wp_get_attachment_id3_keys( $attachment, 'js' ) as $key => $label ) {