Ticket #39696: 39696.1.diff

src/wp-includes/rest-api/class-wp-rest-server.php

@@ -544 +544 @@
 
                 $embedded = array();
 
+                // Get link relationships to filter on, but only if not _embed=1 or _embed=true or empty _embed=
+                $filtered_rels = false;
+                if ( isset( $_GET['_embed'] ) && '1' !==  $_GET['_embed'] && 'true' !== $_GET['_embed'] ) {
+                        $filtered_rels = array_filter( is_array( $_GET['_embed'] ) ? $_GET['_embed'] : explode( ',', $_GET['_embed'] ) );
+                }
+
                 foreach ( $data['_links'] as $rel => $links ) {
                         // Ignore links to self, for obvious reasons.
                         if ( 'self' === $rel ) {
                                 continue;
                         }
 
+                        // If filtered rels are specified and current $rel is not in the list, then continue.
+                        if ( ! empty( $filtered_rels ) && ! in_array( $rel, $filtered_rels, true ) ) {
+                                continue;
+                        }
+
                         $embeds = array();
 
                         foreach ( $links as $item ) {

tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -942 +942 @@
                 $this->assertEquals( rest_url( '/wp/v2/users/' . self::$author_id ), $links['author'][0]['href'] );
         }
 
+        public function test_get_item__embed() {
+
+                // Prepare a new post. This will be first item when querying /wp/v2/posts
+                wp_set_current_user( self::$editor_id );
+                $post_id   = $this->factory->post->create();
+                $category1 = wp_insert_term( 'Embed Test Category', 'category' );
+                $category2 = wp_insert_term( 'Second Embed Test Category', 'category' );
+                wp_set_post_categories( $post_id, array( $category1['term_id'], $category2['term_id'] ) );
+                $this->factory->comment->create_post_comments( $post_id, 1 );
+
+                // Not ideal, but since WP_REST_Server uses $_GET for _embed we need to use this in the tests.
+                // ?_embed=1 should return all expected embeds. In this case 'author', 'replies' and 'wp:term'.
+                $_GET     = array( '_embed' => '1' );
+                $request  = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+                $response = $this->server->dispatch( $request );
+                $data     = $response->get_data();
+                $data     = array_shift( $data );
+                $embeds   = $this->server->embed_links( $data );
+
+                $this->assertArrayHasKey( 'author', $embeds['_embedded'] );
+                $this->assertArrayHasKey( 'replies', $embeds['_embedded'] );
+                $this->assertArrayHasKey( 'wp:term', $embeds['_embedded'] );
+
+                // Not ideal, but since WP_REST_Server uses $_GET for _embed we need to use this in the tests.
+                // ?_embed=true should return all expected embeds. In this case 'author', 'replies' and 'wp:term'.
+                $_GET     = array( '_embed' => 'true' );
+                $request  = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+                $response = $this->server->dispatch( $request );
+                $data     = $response->get_data();
+                $data     = array_shift( $data );
+                $embeds   = $this->server->embed_links( $data );
+
+                $this->assertArrayHasKey( 'author', $embeds['_embedded'] );
+                $this->assertArrayHasKey( 'replies', $embeds['_embedded'] );
+                $this->assertArrayHasKey( 'wp:term', $embeds['_embedded'] );
+
+                // Not ideal, but since WP_REST_Server uses $_GET for _embed we need to use this in the tests.
+                // ?_embed=author,wp:term should return only relevant embeds.
+                $_GET     = array( '_embed' => 'author,wp:term' );
+                $request  = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+                $response = $this->server->dispatch( $request );
+                $data     = $response->get_data();
+                $data     = array_shift( $data );
+                $embeds   = $this->server->embed_links( $data );
+
+                $this->assertArrayHasKey( 'author', $embeds['_embedded'] );
+                $this->assertArrayNotHasKey( 'replies', $embeds['_embedded'] );
+                $this->assertArrayHasKey( 'wp:term', $embeds['_embedded'] );
+
+                // Not ideal, but since WP_REST_Server uses $_GET for _embed we need to use this in the tests.
+                // ?_embed[]=author&_embed[]=replies should return only relevant embeds.
+                $_GET = array(
+                        '_embed' => array(
+                                'author',
+                                'replies',
+                        )
+                );
+
+                $request  = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+                $response = $this->server->dispatch( $request );
+                $data     = $response->get_data();
+                $data     = array_shift( $data );
+                $embeds   = $this->server->embed_links( $data );
+
+                $this->assertArrayHasKey( 'author', $embeds['_embedded'] );
+                $this->assertArrayHasKey( 'replies', $embeds['_embedded'] );
+                $this->assertArrayNotHasKey( 'wp:term', $embeds['_embedded'] );
+        }
+
         public function test_get_post_without_permission() {
                 $draft_id = $this->factory->post->create( array(
                         'post_status' => 'draft',