Ticket #39933: 39933.5.diff

src/wp-includes/rest-api/class-wp-rest-request.php

@@ -364 +364 @@
                         $this->parse_body_params();
                 }
 
-                $accepts_body_data = array( 'POST', 'PUT', 'PATCH' );
+                $accepts_body_data = array( 'POST', 'PUT', 'PATCH', 'DELETE' );
                 if ( in_array( $this->method, $accepts_body_data ) ) {
                         $order[] = 'POST';
                 }

tests/phpunit/tests/rest-api/rest-request.php

@@ -203 +203 @@
                 $this->assertEmpty( $this->request->get_param( 'has_json_params' ) );
         }
 
+        public function non_post_http_methods_with_request_body_provider() {
+                return array(
+                        array( 'PUT' ),
+                        array( 'PATCH' ),
+                        array( 'DELETE' ),
+                );
+        }
+
         /**
-         * PUT requests don't get $_POST automatically parsed, so ensure that
-         * WP_REST_Request does it for us.
+         * Tests that methods supporting request bodies have access to the
+         * request's body.  For POST this is straightforward via `$_POST`; for
+         * other methods `WP_REST_Request` needs to parse the body for us.
+         *
+         * @dataProvider non_post_http_methods_with_request_body_provider
          */
-        public function test_parameters_for_put() {
+        public function test_non_post_body_parameters( $request_method ) {
                 $data = array(
-                        'foo' => 'bar',
+                        'foo'  => 'bar',
                         'alot' => array(
                                 'of' => 'parameters',
                         ),
@@ -219 +230 @@
                                 'stuff',
                         ),
                 );
-
-                $this->request->set_method( 'PUT' );
+                $this->request->set_method( $request_method );
                 $this->request->set_body_params( array() );
                 $this->request->set_body( http_build_query( $data ) );
-
                 foreach ( $data as $key => $expected_value ) {
-                        $this->assertEquals( $expected_value, $this->request->get_param( $key ) );
+                        $this->assertEquals(
+                                $expected_value,
+                                $this->request->get_param( $key ),
+                                "Body parameters for $request_method"
+                        );
                 }
         }