Ticket #39953: 39953.1.patch

src/wp-includes/post.php

@@ -345 +345 @@
                                 'Draft <span class="count">(%s)</span>',
                                 'Drafts <span class="count">(%s)</span>'
                         ),
+                        'date_floating' => true,
                 )
         );
 
@@ -397 +398 @@
                         'label'    => 'auto-draft',
                         'internal' => true,
                         '_builtin' => true, /* internal use only. */
+                        'date_floating' => true
                 )
         );
 
@@ -1018 +1020 @@
  *                                                  the top of the edit listings,
  *                                                  e.g. All (12) | Published (9) | My Custom Status (2)
  *                                                  Default is value of $internal.
+ *     @type bool        $date_floating             Whether the post has a floating creation date.
+ *                                                  Default to false.
  * }
  * @return object
  */
@@ -1041 +1045 @@
                 'publicly_queryable'        => null,
                 'show_in_admin_status_list' => null,
                 'show_in_admin_all_list'    => null,
+                'date_floating'             => null,
         );
         $args     = wp_parse_args( $args, $defaults );
         $args     = (object) $args;
@@ -1085 +1090 @@
                 $args->show_in_admin_status_list = ! $args->internal;
         }
 
+        if ( null === $args->date_floating ) {
+                $args->date_floating = false;
+        }
+
         if ( false === $args->label ) {
                 $args->label = $post_status;
         }

src/wp-includes/rest-api/endpoints/class-wp-rest-post-statuses-controller.php

@@ -234 +234 @@
                         $data['slug'] = $status->name;
                 }
 
+                if ( in_array('date_floating', $fields, true ) ) {
+                        $data['date_floating'] = $status->date_floating;
+                }
+
                 $context = ! empty( $request['context'] ) ? $request['context'] : 'view';
                 $data    = $this->add_additional_fields_to_object( $data, $request );
                 $data    = $this->filter_response_by_context( $data, $context );
@@ -319 +323 @@
                                         'context'     => array( 'embed', 'view', 'edit' ),
                                         'readonly'    => true,
                                 ),
+                                'date_floating'=> array(
+                                        'description' => __( 'Whether posts of this status may have floating published dates.' ),
+                                        'type'        => 'boolean',
+                                        'context'     => array( 'view', 'edit' ),
+                                        'readonly'    => true
+                                )
                         ),
                 );
 

src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1021 +1021 @@
 
                 // Post date.
                 if ( ! empty( $schema['properties']['date'] ) && ! empty( $request['date'] ) ) {
+                        $current_date = isset( $prepared_post->ID ) ? get_post( $prepared_post->ID )->post_date : false;
                         $date_data = rest_get_date_with_gmt( $request['date'] );
 
-                        if ( ! empty( $date_data ) ) {
+                        if ( ! empty( $date_data ) && $current_date !== $date_data[0] ) {
                                 list( $prepared_post->post_date, $prepared_post->post_date_gmt ) = $date_data;
                                 $prepared_post->edit_date                                        = true;
                         }
                 } elseif ( ! empty( $schema['properties']['date_gmt'] ) && ! empty( $request['date_gmt'] ) ) {
+                        $current_date = isset( $prepared_post->ID ) ? get_post( $prepared_post->ID )->post_date_gmt : false;
                         $date_data = rest_get_date_with_gmt( $request['date_gmt'], true );
 
-                        if ( ! empty( $date_data ) ) {
+                        if ( ! empty( $date_data ) && $current_date !== $date_data[1] ) {
                                 list( $prepared_post->post_date, $prepared_post->post_date_gmt ) = $date_data;
                                 $prepared_post->edit_date                                        = true;
                         }

tests/phpunit/tests/rest-api/rest-post-statuses-controller.php

@@ -153 +153 @@
                 $response   = rest_get_server()->dispatch( $request );
                 $data       = $response->get_data();
                 $properties = $data['schema']['properties'];
-                $this->assertEquals( 7, count( $properties ) );
+                $this->assertEquals( 8, count( $properties ) );
                 $this->assertArrayHasKey( 'name', $properties );
                 $this->assertArrayHasKey( 'private', $properties );
                 $this->assertArrayHasKey( 'protected', $properties );
@@ -161 +161 @@
                 $this->assertArrayHasKey( 'queryable', $properties );
                 $this->assertArrayHasKey( 'show_in_list', $properties );
                 $this->assertArrayHasKey( 'slug', $properties );
+                $this->assertArrayhasKey( 'date_floating', $properties );
         }
 
         public function test_get_additional_field_registration() {
@@ -217 +218 @@
                         ),
                         array_keys( $links )
                 );
+                $this->assertEquals( $status_obj->date_floating, $data['date_floating']);
         }
 
         protected function check_post_status_object_response( $response ) {

tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -4283 +4283 @@
 
         }
 
+        public function test_putting_same_publish_date_does_not_remove_floating_date() {
+
+                wp_set_current_user( self::$superadmin_id );
+
+                $time = date( 'Y-m-d H:i:s' );
+
+                $post = self::factory()->post->create_and_get( array(
+                        'post_status' => 'draft',
+                        'post_date'   => $time,
+                ) );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+                $get = new WP_REST_Request( 'GET', "/wp/v2/posts/{$post->ID}" );
+                $get->set_query_params( array( 'context' => 'edit' ) );
+
+                $get      = rest_get_server()->dispatch( $get );
+                $get_body = $get->get_data();
+
+                $put = new WP_REST_Request( 'PUT', "/wp/v2/posts/{$post->ID}" );
+                $put->set_body_params( $get_body );
+
+                $response = rest_get_server()->dispatch( $put );
+                $body     = $response->get_data();
+
+                $this->assertEquals( $get_body['date'], $body['date'] );
+                $this->assertEquals( $get_body['date_gmt'], $body['date_gmt'] );
+
+                $this->assertEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
+        }
+
+        public function test_putting_different_publish_date_removes_floating_date() {
+
+                wp_set_current_user( self::$superadmin_id );
+
+                $time     = date( 'Y-m-d H:i:s' );
+                $new_time = date( 'Y-m-d H:i:s', strtotime( '+1 week' ) );
+
+                $post = self::factory()->post->create_and_get( array(
+                        'post_status' => 'draft',
+                        'post_date'   => $time,
+                ) );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+                $get = new WP_REST_Request( 'GET', "/wp/v2/posts/{$post->ID}" );
+                $get->set_query_params( array( 'context' => 'edit' ) );
+
+                $get      = rest_get_server()->dispatch( $get );
+                $get_body = $get->get_data();
+
+                $put = new WP_REST_Request( 'PUT', "/wp/v2/posts/{$post->ID}" );
+                $put->set_body_params( array_merge( $get_body, array(
+                        'date' => mysql_to_rfc3339( $new_time ),
+                ) ) );
+
+                $response = rest_get_server()->dispatch( $put );
+                $body     = $response->get_data();
+
+                $this->assertEquals( mysql_to_rfc3339( $new_time ), $body['date'] );
+
+                $this->assertNotEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
+        }
+
+        public function test_publishing_post_with_same_date_removes_floating_date() {
+
+                wp_set_current_user( self::$superadmin_id );
+
+                $time = date( 'Y-m-d H:i:s' );
+
+                $post = self::factory()->post->create_and_get( array(
+                        'post_status' => 'draft',
+                        'post_date'   => $time,
+                ) );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+                $get = new WP_REST_Request( 'GET', "/wp/v2/posts/{$post->ID}" );
+                $get->set_query_params( array( 'context' => 'edit' ) );
+
+                $get      = rest_get_server()->dispatch( $get );
+                $get_body = $get->get_data();
+
+                $put = new WP_REST_Request( 'PUT', "/wp/v2/posts/{$post->ID}" );
+                $put->set_body_params( array_merge( $get_body, array(
+                        'status' => 'publish',
+                ) ) );
+
+                $response = rest_get_server()->dispatch( $put );
+                $body     = $response->get_data();
+
+                $this->assertEquals( $get_body['date'], $body['date'] );
+                $this->assertEquals( $get_body['date_gmt'], $body['date_gmt'] );
+
+                $this->assertNotEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
+        }
+
         public function tearDown() {
                 _unregister_post_type( 'private-post' );
                 _unregister_post_type( 'youseeme' );