Ticket #39953: 39953.diff

src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -999 +999 @@
 
                 // Post date.
                 if ( ! empty( $schema['properties']['date'] ) && ! empty( $request['date'] ) ) {
+                        $current_date = isset( $prepared_post->ID ) ? get_post( $prepared_post->ID )->post_date : false;
                         $date_data = rest_get_date_with_gmt( $request['date'] );
 
-                        if ( ! empty( $date_data ) ) {
+                        if ( ! empty( $date_data ) && $current_date !== $date_data[0] ) {
                                 list( $prepared_post->post_date, $prepared_post->post_date_gmt ) = $date_data;
                                 $prepared_post->edit_date                                        = true;
                         }
                 } elseif ( ! empty( $schema['properties']['date_gmt'] ) && ! empty( $request['date_gmt'] ) ) {
+                        $current_date = isset( $prepared_post->ID ) ? get_post( $prepared_post->ID )->post_date_gmt : false;
                         $date_data = rest_get_date_with_gmt( $request['date_gmt'], true );
 
-                        if ( ! empty( $date_data ) ) {
+                        if ( ! empty( $date_data ) && $current_date !== $date_data[1] ) {
                                 list( $prepared_post->post_date, $prepared_post->post_date_gmt ) = $date_data;
                                 $prepared_post->edit_date                                        = true;
                         }

tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -3992 +3992 @@
                 $this->assertArrayHasKey( 'https://api.w.org/action-assign-tags', $links );
         }
 
+        public function test_putting_same_publish_date_does_not_remove_floating_date() {
+
+                wp_set_current_user( self::$superadmin_id );
+
+                $time = date( 'Y-m-d H:i:s' );
+
+                $post = self::factory()->post->create_and_get( array(
+                        'post_status' => 'draft',
+                        'post_date'   => $time,
+                ) );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+                $get = new WP_REST_Request( 'GET', "/wp/v2/posts/{$post->ID}" );
+                $get->set_query_params( array( 'context' => 'edit' ) );
+
+                $get      = rest_get_server()->dispatch( $get );
+                $get_body = $get->get_data();
+
+                $put = new WP_REST_Request( 'PUT', "/wp/v2/posts/{$post->ID}" );
+                $put->set_body_params( $get_body );
+
+                $response = rest_get_server()->dispatch( $put );
+                $body     = $response->get_data();
+
+                $this->assertEquals( $get_body['date'], $body['date'] );
+                $this->assertEquals( $get_body['date_gmt'], $body['date_gmt'] );
+
+                $this->assertEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
+        }
+
+        public function test_putting_different_publish_date_removes_floating_date() {
+
+                wp_set_current_user( self::$superadmin_id );
+
+                $time     = date( 'Y-m-d H:i:s' );
+                $new_time = date( 'Y-m-d H:i:s', strtotime( '+1 week' ) );
+
+                $post = self::factory()->post->create_and_get( array(
+                        'post_status' => 'draft',
+                        'post_date'   => $time,
+                ) );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+                $get = new WP_REST_Request( 'GET', "/wp/v2/posts/{$post->ID}" );
+                $get->set_query_params( array( 'context' => 'edit' ) );
+
+                $get      = rest_get_server()->dispatch( $get );
+                $get_body = $get->get_data();
+
+                $put = new WP_REST_Request( 'PUT', "/wp/v2/posts/{$post->ID}" );
+                $put->set_body_params( array_merge( $get_body, array(
+                        'date' => mysql_to_rfc3339( $new_time ),
+                ) ) );
+
+                $response = rest_get_server()->dispatch( $put );
+                $body     = $response->get_data();
+
+                $this->assertEquals( mysql_to_rfc3339( $new_time ), $body['date'] );
+
+                $this->assertNotEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
+        }
+
+        public function test_publishing_post_with_same_date_removes_floating_date() {
+
+                wp_set_current_user( self::$superadmin_id );
+
+                $time = date( 'Y-m-d H:i:s' );
+
+                $post = self::factory()->post->create_and_get( array(
+                        'post_status' => 'draft',
+                        'post_date'   => $time,
+                ) );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+                $get = new WP_REST_Request( 'GET', "/wp/v2/posts/{$post->ID}" );
+                $get->set_query_params( array( 'context' => 'edit' ) );
+
+                $get      = rest_get_server()->dispatch( $get );
+                $get_body = $get->get_data();
+
+                $put = new WP_REST_Request( 'PUT', "/wp/v2/posts/{$post->ID}" );
+                $put->set_body_params( array_merge( $get_body, array(
+                        'status' => 'publish',
+                ) ) );
+
+                $response = rest_get_server()->dispatch( $put );
+                $body     = $response->get_data();
+
+                $this->assertEquals( $get_body['date'], $body['date'] );
+                $this->assertEquals( $get_body['date_gmt'], $body['date_gmt'] );
+
+                $this->assertNotEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
+        }
+
         public function tearDown() {
                 _unregister_post_type( 'youseeeme' );
                 if ( isset( $this->attachment_id ) ) {