Ticket #40187: 40187.2.diff

src/wp-admin/css/edit.css

@@ -574 +574 @@
         position: absolute;
 }
 
-.tagchecklist > span {
+.tagchecklist > li {
+        display: inline-block;
         float: left;
         margin-right: 25px;
         font-size: 13px;
@@ -1051 +1052 @@
         margin: 2px 0 12px;
 }
 
+.the-tagcloud ul {
+        margin: 0;
+}
+
+.the-tagcloud ul li {
+        display: inline-block;
+}
+
 /* Suggest.js autocomplete, no more used by core. */
 .ac_results {
         display: none;
@@ -1440 +1449 @@
                 margin: 25px 10px;
         }
 
-        .tagchecklist > span {
+        .tagchecklist > li {
                 font-size: 16px;
                 line-height: 1.4;
         }

src/wp-admin/css/press-this.css

@@ -765 +765 @@
 
 /* Tags */
 .tagchecklist {
+        margin: 0;
         padding: 16px 28px 5px;
+        list-style: none;
 }
 
 .tagchecklist:before,
@@ -778 +780 @@
         clear: both;
 }
 
-.tagchecklist > span {
+.tagchecklist > li {
+        display: inline-block;
         float: left;
         margin-right: 25px;
         font-size: 13px;
@@ -788 +791 @@
 }
 
 @media (max-width: 600px) {
-        .tagchecklist > span {
+        .tagchecklist > li {
                 margin-bottom: 15px;
                 font-size: 16px;
                 line-height: 1.3;
@@ -877 +880 @@
         padding: 16px;
 }
 
+.the-tagcloud ul {
+        margin: 0;
+        list-style: none;
+}
+
+.the-tagcloud ul li {
+        display: inline-block;
+}
+
 .the-tagcloud a {
         text-decoration: none;
         outline: 0;

src/wp-admin/includes/ajax-actions.php

@@ -963 +963 @@
         }
 
         // We need raw tag names here, so don't filter the output
-        $return = wp_generate_tag_cloud( $tags, array('filter' => 0) );
+        $return = wp_generate_tag_cloud( $tags, array('filter' => 0, 'format' => 'list') );
 
         if ( empty($return) )
                 wp_die( 0 );

src/wp-admin/includes/class-wp-press-this.php

@@ -947 +947 @@
 
                         ?>
                         </div>
-                        <div class="tagchecklist"></div>
+                        <ul class="tagchecklist"></ul>
                 </div>
                 <?php
 

src/wp-admin/includes/meta-boxes.php

@@ -453 +453 @@
                 <p><?php echo $taxonomy->labels->no_terms; ?></p>
         <?php endif; ?>
         </div>
-        <div class="tagchecklist"></div>
+        <ul class="tagchecklist"></ul>
 </div>
 <?php if ( $user_can_assign_terms ) : ?>
 <p class="hide-if-no-js"><button type="button" class="button-link tagcloud-link" id="link-<?php echo $tax_name; ?>" aria-expanded="false"><?php echo $taxonomy->labels->choose_from_most_used; ?></button></p>

src/wp-admin/js/tags-box.js

@@ -74 +74 @@
                         tagchecklist.empty();
 
                         $.each( current_tags, function( key, val ) {
-                                var span, xbutton;
+                                var item, xbutton;
 
                                 val = $.trim( val );
 
                                 if ( ! val )
                                         return;
 
-                                // Create a new span, and ensure the text is properly escaped.
-                                span = $('<span />').text( val );
+                                // Create a new item, and ensure the text is properly escaped.
+                                item = $('<li />').text( val );
 
                                 // If tags editing isn't disabled, create the X button.
                                 if ( ! disabled ) {
@@ -92 +92 @@
                                          */
                                         xbutton = $( '<button type="button" id="' + id + '-check-num-' + key + '" class="ntdelbutton">' +
                                                 '<span class="remove-tag-icon" aria-hidden="true"></span>' +
-                                                '<span class="screen-reader-text">' + window.tagsSuggestL10n.removeTerm + ' ' + span.html() + '</span>' +
+                                                '<span class="screen-reader-text">' + window.tagsSuggestL10n.removeTerm + ' ' + item.html() + '</span>' +
                                                 '</button>' );
 
                                         xbutton.on( 'click keypress', function( e ) {
@@ -112 +112 @@
                                                 }
                                         });
 
-                                        span.prepend( '&nbsp;' ).prepend( xbutton );
+                                        item.prepend( '&nbsp;' ).prepend( xbutton );
                                 }
 
-                                // Append the span to the tag list.
-                                tagchecklist.append( span );
+                                // Append the item to the tag list.
+                                tagchecklist.append( item );
                         });
                         // The buttons list is built now, give feedback to screen reader users.
                         tagBox.screenReadersMessage();
@@ -166 +166 @@
                                         return;
                                 }
 
-                                r = $( '<p id="tagcloud-' + tax + '" class="the-tagcloud">' + r + '</p>' );
+                                r = $( '<div id="tagcloud-' + tax + '" class="the-tagcloud">' + r + '</div>' );
 
                                 $( 'a', r ).click( function() {
                                         tagBox.userAction = 'add';