Ticket #40213: 40213.1.diff

src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php

@@ -221 +221 @@
                         'per_page' => 'number',
                         'search'   => 'search',
                         'roles'    => 'role__in',
+                        'slug'     => 'nicename__in'
                 );
 
                 $prepared_args = array();
@@ -261 +262 @@
                 if ( ! empty( $prepared_args['search'] ) ) {
                         $prepared_args['search'] = '*' . $prepared_args['search'] . '*';
                 }
-
-                if ( isset( $registered['slug'] ) && ! empty( $request['slug'] ) ) {
-                        $prepared_args['search'] = $request['slug'];
-                        $prepared_args['search_columns'] = array( 'user_nicename' );
-                }
-
                 /**
                  * Filters WP_User_Query arguments when querying users via the REST API.
                  *
@@ -278 +273 @@
                  * @param WP_REST_Request $request       The current request.
                  */
                 $prepared_args = apply_filters( 'rest_user_query', $prepared_args, $request );
-
                 $query = new WP_User_Query( $prepared_args );
 
                 $users = array();
@@ -1363 +1357 @@
                 );
 
                 $query_params['slug']    = array(
-                        'description'        => __( 'Limit result set to users with a specific slug.' ),
-                        'type'               => 'string',
+                        'description'           => __( 'Limit result set to users with a specific slug.' ),
+                        'type'                          => 'array',
+                        'items'                         => array(
+                                'type'                  => 'string',
+                        )
                 );
 
                 $query_params['roles']   = array(

tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -574 +574 @@
                 $this->assertEquals( $id2, $data[0]['id'] );
         }
 
+        public function test_get_items_slug_array_query() {
+                wp_set_current_user( self::$user );
+                $id1 = $this->factory->user->create( array( 'display_name' => 'Taco', 'user_login' => 'taco' ) );
+                $id2 = $this->factory->user->create( array( 'display_name' => 'Enchilada', 'user_login' => 'enchilada' ) );
+                $id3 = $this->factory->user->create( array( 'display_name' => 'Burrito', 'user_login' => 'burrito' ) );
+                $this->factory->user->create( array( 'display_name' => 'Hon Pizza', 'user_login' => 'pizza' ) );
+                $request = new WP_REST_Request( 'GET', '/wp/v2/users' );
+                $request->set_param( 'slug', array(
+                        'taco',
+                        'burrito',
+                        'enchilada',
+                ) );
+                $request->set_param( 'orderby', 'slug' );
+                $request->set_param( 'order', 'desc' );
+                $response = $this->server->dispatch( $request );
+                $this->assertEquals( 200, $response->get_status() );
+                $data = $response->get_data();
+                $this->assertEquals( 3, count( $data ) );
+                $this->assertEquals( $id1, $data[0]['id'] );
+                $this->assertEquals( $id2, $data[1]['id'] );
+                $this->assertEquals( $id3, $data[2]['id'] );
+        }
+
+        public function test_get_items_csv_array_query() {
+                wp_set_current_user( self::$user );
+                $id1 = $this->factory->user->create( array( 'display_name' => 'Taco', 'user_login' => 'taco' ) );
+                $id2 = $this->factory->user->create( array( 'display_name' => 'Enchilada', 'user_login' => 'enchilada' ) );
+                $id3 = $this->factory->user->create( array( 'display_name' => 'Burrito', 'user_login' => 'burrito' ) );
+                $this->factory->user->create( array( 'display_name' => 'Hon Pizza', 'user_login' => 'pizza' ) );
+                $request = new WP_REST_Request( 'GET', '/wp/v2/users' );
+                $request->set_param( 'slug', 'taco, burrito, enchilada');
+                $request->set_param( 'orderby', 'slug' );
+                $request->set_param( 'order', 'desc' );
+                $response = $this->server->dispatch( $request );
+                $this->assertEquals( 200, $response->get_status() );
+                $data = $response->get_data();
+                $this->assertEquals( 3, count( $data ) );
+                $this->assertEquals( $id1, $data[0]['id'] );
+                $this->assertEquals( $id2, $data[1]['id'] );
+                $this->assertEquals( $id3, $data[2]['id'] );
+        }
+
         // Note: Do not test using editor role as there is an editor role created in testing and it makes it hard to test this functionality.
         public function test_get_items_roles() {
                 wp_set_current_user( self::$user );