Ticket #40270: 40270.diff

tests/phpunit/includes/testcase-rest-post-type-controller.php

@@ -202 +202 @@
         protected function check_get_posts_response( $response, $context = 'view' ) {
                 $this->assertNotInstanceOf( 'WP_Error', $response );
                 $response = rest_ensure_response( $response );
+                $this->assertNotInstanceOf( 'WP_Error', $response->as_error() );
                 $this->assertEquals( 200, $response->get_status() );
 
                 $headers = $response->get_headers();
@@ -229 +230 @@
         protected function check_get_post_response( $response, $context = 'view' ) {
                 $this->assertNotInstanceOf( 'WP_Error', $response );
                 $response = rest_ensure_response( $response );
+                $this->assertNotInstanceOf( 'WP_Error', $response->as_error() );
                 $this->assertEquals( 200, $response->get_status() );
 
                 $data = $response->get_data();
@@ -240 +242 @@
         protected function check_create_post_response( $response ) {
                 $this->assertNotInstanceOf( 'WP_Error', $response );
                 $response = rest_ensure_response( $response );
+                $this->assertNotInstanceOf( 'WP_Error', $response->as_error() );
 
                 $this->assertEquals( 201, $response->get_status() );
                 $headers = $response->get_headers();
@@ -253 +256 @@
         protected function check_update_post_response( $response ) {
                 $this->assertNotInstanceOf( 'WP_Error', $response );
                 $response = rest_ensure_response( $response );
+                $this->assertNotInstanceOf( 'WP_Error', $response->as_error() );
 
                 $this->assertEquals( 200, $response->get_status() );
                 $headers = $response->get_headers();

tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -2837 +2837 @@
                 $request->set_param( 'force', 'false' );
                 $response = $this->server->dispatch( $request );
 
-                $this->assertNotInstanceOf( 'WP_Error', $response );
+                $this->assertNotInstanceOf( 'WP_Error', $response->as_error() );
                 $this->assertEquals( 200, $response->get_status() );
                 $data = $response->get_data();
                 $this->assertEquals( 'Deleted post', $data['title']['raw'] );
@@ -2852 +2852 @@
                 $request['force'] = true;
                 $response = $this->server->dispatch( $request );
 
-                $this->assertNotInstanceOf( 'WP_Error', $response );
+                $this->assertNotInstanceOf( 'WP_Error', $response->as_error() );
                 $this->assertEquals( 200, $response->get_status() );
                 $data = $response->get_data();
                 $this->assertTrue( $data['deleted'] );