Ticket #40306: 40306.diff

src/wp-includes/taxonomy.php

@@ -2282 +2282 @@
         }
 
         wp_cache_delete( $object_id, $taxonomy . '_relationships' );
+        wp_cache_delete( 'last_changed', 'terms' );
 
         /**
          * Fires after an object's terms have been set.
@@ -2376 +2377 @@
                 $deleted = $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->term_relationships WHERE object_id = %d AND term_taxonomy_id IN ($in_tt_ids)", $object_id ) );
 
                 wp_cache_delete( $object_id, $taxonomy . '_relationships' );
+                wp_cache_delete( 'last_changed', 'terms' );
 
                 /**
                  * Fires immediately after an object-term relationship is deleted.

tests/phpunit/tests/term/getTheTerms.php

@@ -191 +191 @@
                 $this->assertSame( $num_queries, $wpdb->num_queries );
 
         }
+
+        public function test_defer_term_counting_term_cache( $value = null ) {
+                // Temporarily disable term counting.
+                wp_defer_term_counting( true );
+
+                // Create Test Category.
+                $term_id = self::factory()->category->create( array(
+                        'slug' => 'uncounted-category',
+                ) );
+
+                // Create the blank post object to mimic the "Write" screen.
+                $post = get_default_post_to_edit( 'post', true );
+
+                // Save a draft of the post.
+                wp_update_post( array(
+                        'ID' => $post->ID,
+                        'post_status' => 'draft',
+                        'post_title' => 'some-post',
+                        'post_type' => 'post',
+                        'post_content' => 'some_content',
+                        'post_category' => array( $term_id ),
+                ) );
+
+                // Ensure that caches were cleared.
+                $terms = get_the_terms( $post->ID, 'category' );
+
+                // Re-activate term counting so this doesn't affect other tests. This
+                // doesn't affect the assertions because `$terms` is already populated.
+                wp_defer_term_counting( false );
+
+                $this->assertTrue( is_array( $terms ) );
+                $this->assertSame( array( $term_id ), wp_list_pluck( $terms, 'term_id' ) );
+        }
 }