Ticket #40386: 40386.diff

src/wp-includes/ms-functions.php

@@ -2274 +2274 @@
  * Update the network-wide counts for the current network.
  *
  * @since 3.1.0
+ * @since 4.8.0 The $network_id parameter has been added.
+ *
+ * @param int|null $network_id ID of the network. Default is the current network.
  */
-function wp_update_network_counts() {
-        wp_update_network_user_counts();
-        wp_update_network_site_counts();
+function wp_update_network_counts( $network_id = null ) {
+        wp_update_network_user_counts( $network_id );
+        wp_update_network_site_counts( $network_id );
 }
 
 /**

tests/phpunit/tests/multisite/network.php

@@ -440 +440 @@
                 $result = get_user_count( self::$different_network_id );
                 $this->assertEquals( $expected, $result );
         }
+
+        /**
+         * @ticket 40386
+         */
+        public function test_wp_update_network_counts() {
+                delete_network_option( null, 'site_count' );
+                delete_network_option( null, 'user_count' );
+
+                wp_update_network_counts();
+
+                $site_count = (int) get_blog_count();
+                $user_count = (int) get_user_count();
+
+                $this->assertTrue( $site_count > 0 && $user_count > 0 );
+        }
+
+        /**
+         * @ticket 40386
+         */
+        public function test_wp_update_network_counts_on_different_network() {
+                delete_network_option( self::$different_network_id, 'site_count' );
+                delete_network_option( self::$different_network_id, 'user_count' );
+
+                wp_update_network_counts( self::$different_network_id );
+
+                $site_count = (int) get_blog_count( self::$different_network_id );
+                $user_count = (int) get_user_count( self::$different_network_id );
+
+                $this->assertTrue( $site_count > 0 && $user_count > 0 );
+        }
 }
 
 endif;