Ticket #40590: 40590-3.diff

.php

@@ -2580 +2580 @@
         if ( 'mediaelement' === $library && 1 === $instance ) {
                 $html .= "<!--[if lt IE 9]><script>document.createElement('video');</script><![endif]-->\n";
         }
-        //$html .= sprintf( '<video %s controls="controls">', join( ' ', $attr_strings ) );
 
-        if ( isset( $attr['controls'] ) && in_array( $attr['controls'], array( 'false', 'off', '0' ), true ) ) {
+        if( isset( $attr['controls'] ))
+        {
+                if ( in_array( $attr['controls'], array( 'true', 'on', '1' ), true ) ) {
+                        $html .= sprintf( '<video %s controls="controls">', join( ' ', $attr_strings ) );
+                } else {
+                        $html .= sprintf( '<video %s>', join( ' ', $attr_strings ) );
+                }
+        }
+        else
+        {
                 $html .= sprintf( '<video %s>', join( ' ', $attr_strings ) );
-        } else {
-                $html .= sprintf( '<video %s controls="controls">', join( ' ', $attr_strings ) );
         }
 
         $fileurl = '';