Ticket #40927: 40927.diff

src/wp-admin/includes/plugin.php

@@ -1081 +1081 @@
         $hookname = get_plugin_page_hookname( $menu_slug, '' );
 
         if ( !empty( $function ) && !empty( $hookname ) && current_user_can( $capability ) )
                 add_action( $hookname, $function );
 
         if ( empty($icon_url) ) {
                 $icon_url = 'dashicons-admin-generic';
                 $icon_class = 'menu-icon-generic ';
         } else {
                 $icon_url = set_url_scheme( $icon_url );
                 $icon_class = '';
         }
 
         $new_menu = array( $menu_title, $capability, $menu_slug, $page_title, 'menu-top ' . $icon_class . $hookname, $hookname, $icon_url );
 
+        // PHP truncates floats to an int for array indicies.
+        if ( is_float( $position ) ) {
+                $position = (string) $position;
+        }
+
         if ( null === $position ) {
                 $menu[] = $new_menu;
         } elseif ( isset( $menu[ "$position" ] ) ) {
                 $position = $position + substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ) , -5 ) * 0.00001;
                 $menu[ "$position" ] = $new_menu;
         } else {
                 $menu[ $position ] = $new_menu;
         }
 
         $_registered_pages[$hookname] = true;
 
         // No parent as top level
         $_parent_pages[$menu_slug] = false;
 
         return $hookname;