Ticket #41143: 41143_4.diff

src/wp-admin/js/theme-plugin-editor.js

@@ -73 +73 @@
                         }
                         return undefined;
                 } );
+
+                /**
+                 * Activates / Deactivates Documentation Lookup Button
+                 *
+                 * @since 5.0.0
+                 * @type {*|HTMLElement}
+                 */
+
+                var docsList = $('#docs-list');
+                var docsListButton = $('#docs-list-button');
+
+                docsList.on( 'change', function() {
+                        if ( '' !== $( this ).val() ) {
+                                docsListButton.prop('disabled', false);
+                        } else {
+                                docsListButton.prop('disabled', true);
+                        }
+                } );
         };
 
         /**

src/wp-admin/plugin-editor.php

@@ -265 +265 @@
                         <input type="hidden" name="plugin" value="<?php echo esc_attr( $plugin ); ?>" />
                 </div>
                 <?php if ( ! empty( $docs_select ) ) : ?>
-                <div id="documentation" class="hide-if-no-js"><label for="docs-list"><?php _e( 'Documentation:' ); ?></label> <?php echo $docs_select; ?> <input type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" /></div>
+                <div id="documentation" class="hide-if-no-js"><label for="docs-list"><?php _e( 'Documentation:' ); ?></label> <?php echo $docs_select; ?> <input disabled type="button" id="docs-list-button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" /></div>
                 <?php endif; ?>
 <?php if ( is_writeable( $real_file ) ) : ?>
         <div class="editor-notices">

src/wp-admin/theme-editor.php

@@ -285 +285 @@
                 <div id="documentation" class="hide-if-no-js">
                 <label for="docs-list"><?php _e( 'Documentation:' ); ?></label>
                 <?php echo $docs_select; ?>
-                <input type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" />
+                <input disabled type="button" id="docs-list-button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" />
                 </div>
         <?php endif; ?>