Ticket #41143: 41143_v3.diff

wp-admin/js/common.js

@@ -1026 +1026 @@
         }
 })();
 
+// Make the Look Up button in Theme / Plugin Editors disabled if nothing is selected.
+$('#documentation #docs-list').change(function(){
+        if ( $( this ).val() != '' ) {
+                $('#documentation #documentationLookup').prop('disabled', false);
+        }
+        else
+        {
+                $('#documentation #documentationLookup').prop('disabled', true);
+        }
+});
+
 }( jQuery, window ));

wp-admin/plugin-editor.php

@@ -272 +272 @@
                 <input type="hidden" name="scrollto" id="scrollto" value="<?php echo $scrollto; ?>" />
                 </div>
                 <?php if ( !empty( $docs_select ) ) : ?>
-                <div id="documentation" class="hide-if-no-js"><label for="docs-list"><?php _e('Documentation:') ?></label> <?php echo $docs_select ?> <input type="button" class="button" value="<?php esc_attr_e( 'Look Up' ) ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ) ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ) ?>&amp;redirect=true'); }" /></div>
+                <div id="documentation" class="hide-if-no-js">
+            <label for="docs-list"><?php _e('Documentation:') ?></label>
+            <?php echo $docs_select ?>
+            <input disabled id="documentationLookup" type="button" class="button" value="<?php esc_attr_e( 'Look Up' ) ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ) ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ) ?>&amp;redirect=true'); }" />
+        </div>
                 <?php endif; ?>
 <?php if ( is_writeable($real_file) ) : ?>
         <?php if ( in_array( $plugin, (array) get_option( 'active_plugins', array() ) ) ) { ?>

wp-admin/theme-editor.php

@@ -263 +263 @@
                 <div id="documentation" class="hide-if-no-js">
                 <label for="docs-list"><?php _e('Documentation:') ?></label>
                 <?php echo $docs_select; ?>
-                <input type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ) ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ) ?>&amp;redirect=true'); }" />
-                </div>
+                <input disabled id="documentationLookup"  type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ) ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ) ?>&amp;redirect=true'); }" />
+        </div>
         <?php endif; ?>
 
                 <div>