Ticket #42069: 42069.2.diff

src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php

@@ -307 +307 @@
                 $meta_key   = wp_slash( $meta_key );
                 $meta_value = wp_slash( $value );
 
-                // Do the exact same check for a duplicate value as in update_metadata() to avoid update_metadata() returning false.
+                /*
+                 * The function update_metadata() has a surprising behavior: it returns false
+                 * if the new value matches the existing value. To avoid returning a server error
+                 * response when updating meta, we must check for values that will be interpreted
+                 * as equivalent by update_metadata() and its underlying function, $wpdb->query().
+                 */
                 $old_value = get_metadata( $meta_type, $object_id, $meta_key );
-
                 if ( 1 === count( $old_value ) ) {
-                        if ( $old_value[0] === $meta_value ) {
+                        $old_check_value  = sanitize_meta( $meta_key, $old_value[0], $meta_type );
+                        $meta_check_value = sanitize_meta( $meta_key, $value, $meta_type );
+                        if ( $old_check_value === $meta_check_value ) {
                                 return true;
                         }
                 }

tests/phpunit/tests/rest-api/rest-post-meta-fields.php

@@ -119 +119 @@
                                 ),
                         )
                 );
+                register_meta(
+                        'post', 'test_boolean_update', array(
+                                'single'            => true,
+                                'type'              => 'boolean',
+                                'sanitize_callback' => 'absint',
+                                'show_in_rest'      => true,
+                        )
+                );
+                register_meta(
+                        'post', 'test_textured_text_update', array(
+                                'single'            => true,
+                                'type'              => 'string',
+                                'sanitize_callback' => 'sanitize_text_field',
+                                'show_in_rest'      => true,
+                        )
+                );
 
                 /** @var WP_REST_Server $wp_rest_server */
                 global $wp_rest_server;
@@ -888 +904 @@
                 $this->assertEquals( $post_original->post_content, $post_updated->post_content );
         }
 
+        /**
+         * @ticket 42069
+         */
+        public function test_update_value_return_success_response_when_updating_boolean_values_no_change() {
+                add_post_meta( self::$post_id, 'test_boolean_update', 0);
+                $post_original = get_post( self::$post_id );
+
+                $this->grant_write_permission();
+
+                $data = array(
+                        'meta' => array(
+                                'test_boolean_update' => 0,
+                        ),
+                );
+
+                $request = new WP_REST_Request( 'POST', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+                $request->set_body_params( $data );
+
+                $response = rest_get_server()->dispatch( $request );
+
+                $this->assertEquals( 200, $response->get_status() );
+        }
+
+        /**
+         * @ticket 42069
+         */
+        public function test_update_value_return_success_response_when_updating_textured_string_values_no_change() {
+                add_post_meta( self::$post_id, 'test_textured_text_update', 'She said, "What about the > 10,000 penguins in the kitchen?"' );
+                $post_original = get_post( self::$post_id );
+
+                $this->grant_write_permission();
+
+                $data = array(
+                        'meta' => array(
+                                'test_textured_text_update' => 'She said, "What about the > 10,000 penguins in the kitchen?"',
+                        ),
+                );
+
+                $request = new WP_REST_Request( 'POST', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+                $request->set_body_params( $data );
+
+                $response = rest_get_server()->dispatch( $request );
+
+                $this->assertEquals( 200, $response->get_status() );
+        }
+
+        /**
+         * @ticket 42069
+         */
+        public function test_update_value_return_success_response_when_updating_textured_string_values_slashed_no_change() {
+                add_post_meta( self::$post_id, 'test_textured_text_update', "He's about to do something rash..." );
+                $post_original = get_post( self::$post_id );
+
+                $this->grant_write_permission();
+
+                $data = array(
+                        'meta' => array(
+                                'test_textured_text_update' => "He's about to do something rash...",
+                        ),
+                );
+
+                $request = new WP_REST_Request( 'POST', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+                $request->set_body_params( $data );
+
+                $response = rest_get_server()->dispatch( $request );
+
+                $this->assertEquals( 200, $response->get_status() );
+        }
+
         public function test_remove_multi_value_db_error() {
                 add_post_meta( self::$post_id, 'test_multi', 'val1' );
                 $values = get_post_meta( self::$post_id, 'test_multi', false );